extra check for syncing (#6771)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
hyperledger · Mar 22, 2024 · 6fcac7b · 6fcac7b
1 parent bee0e5e
commit 6fcac7b
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/...r/besu/tests/acceptance/permissioning/NodeSmartContractPermissioningV2AcceptanceTest.java b/...r/besu/tests/acceptance/permissioning/NodeSmartContractPermissioningV2AcceptanceTest.java
@@ -47,10 +47,7 @@ public void setUp() {
     permissionedNode.execute(allowNode(permissionedNode));
     permissionedNode.verify(connectionIsAllowed(permissionedNode));
 
-    allowedNode.verify(eth.syncingStatus(false));
-    bootnode.verify(eth.syncingStatus(false));
-    permissionedNode.verify(eth.syncingStatus(false));
-    forbiddenNode.verify(eth.syncingStatus(false));
+    verifyAllNodesHaveFinishedSyncing();
   }
 
   @Test
@@ -92,6 +89,8 @@ public void permissioningUpdatesPropagateThroughNetwork() {
     permissionedNode.verify(admin.addPeer(allowedNode));
     permissionedNode.verify(net.awaitPeerCount(2));
 
+    verifyAllNodesHaveFinishedSyncing();
+
     // permissioning changes in peer should propagate to permissioned node
     allowedNode.execute(allowNode(forbiddenNode));
     allowedNode.verify(connectionIsAllowed(forbiddenNode));
@@ -101,6 +100,13 @@ public void permissioningUpdatesPropagateThroughNetwork() {
     permissionedNode.verify(net.awaitPeerCount(3));
   }
 
+  private void verifyAllNodesHaveFinishedSyncing() {
+    allowedNode.verify(eth.syncingStatus(false));
+    bootnode.verify(eth.syncingStatus(false));
+    permissionedNode.verify(eth.syncingStatus(false));
+    forbiddenNode.verify(eth.syncingStatus(false));
+  }
+
   @Test
   public void onchainPermissioningAllowlistShouldPersistAcrossRestarts() {
     permissionedCluster.stop();