Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stricter parsing of genesis JSON #5900

Open
macfarla opened this issue Sep 19, 2023 · 0 comments
Open

stricter parsing of genesis JSON #5900

macfarla opened this issue Sep 19, 2023 · 0 comments
Labels
snack Smaller coding task - less than a day for an experienced dev

Comments

@macfarla
Copy link
Contributor

Original holesky genesis had a missing brace issue #5797

It looks like the missing brace would have parsed the remaining accounts as storage fields? I presume this was possible because of a json parsing policy that ignores missing fields, otherwise we should have thrown when "balance":xx wasn't part of the json schema for storage fields.

can we add stricter json parsing for storage fields and/or test coverage?

See comments here
#5890 (review)
@macfarla macfarla mentioned this issue Sep 19, 2023
Merged
@macfarla macfarla added snack Smaller coding task - less than a day for an experienced dev TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team TeamChupa GH issues worked on by Chupacabara Team labels Sep 20, 2023
@jflo jflo removed TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
snack Smaller coding task - less than a day for an experienced dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jflo @macfarla