Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Holešky as predefined network name #5797

Merged
merged 10 commits into from
Aug 28, 2023
Merged

Add Holešky as predefined network name #5797

merged 10 commits into from
Aug 28, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 24, 2023

PR description

Fixed Issue(s)

@fab-10
Add Holešky testnet network name
8fda514 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited by fab-10
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10
CHANGELOG
183623e 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Aug 24, 2023
fab-10 added 7 commits August 24, 2023 17:55
@fab-10
Add a fake KZG setup since Holesky define Cancun as future fork
d3b6bde 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Tear down KZG trusted setup after each test
6bc9395 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Merge branch 'main' into holesky-testnet
a171ee5
@fab-10
Merge branch 'main' into holesky-testnet
6731ce9
@fab-10
Fix test
bf0369f 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Merge branch 'holesky-testnet' of github.com:fab-10/besu into holesky…
3526752 
…-testnet
@fab-10
Prevent another trusted setup already loaded error during tests
0ca3a3b 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@macfarla macfarla enabled auto-merge (squash) August 28, 2023 00:33
@macfarla macfarla merged commit eb60c06 into hyperledger:main Aug 28, 2023
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
@fab-10 @macfarla @garyschulte
Add Holešky as predefined network name (hyperledger#5797)
72aefad 
* Add Holešky testnet network name

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* CHANGELOG

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Add a fake KZG setup since Holesky define Cancun as future fork

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Tear down KZG trusted setup after each test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Fix test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Prevent another trusted setup already loaded error during tests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
@fab-10 @macfarla @garyschulte
Add Holešky as predefined network name (hyperledger#5797)
44aacf0 
* Add Holešky testnet network name

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* CHANGELOG

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Add a fake KZG setup since Holesky define Cancun as future fork

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Tear down KZG trusted setup after each test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Fix test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Prevent another trusted setup already loaded error during tests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
@fab-10 @macfarla @garyschulte
Add Holešky as predefined network name (hyperledger#5797)
1ca77c4 
* Add Holešky testnet network name

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* CHANGELOG

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Add a fake KZG setup since Holesky define Cancun as future fork

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Tear down KZG trusted setup after each test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Fix test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Prevent another trusted setup already loaded error during tests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@bgravenorst bgravenorst mentioned this pull request Aug 31, 2023
Closed
@bgravenorst bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Aug 31, 2023
@macfarla macfarla mentioned this pull request Sep 19, 2023
Open
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@fab-10 @macfarla @eum602
Add Holešky as predefined network name (hyperledger#5797)
d078076 
* Add Holešky testnet network name

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* CHANGELOG

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Add a fake KZG setup since Holesky define Cancun as future fork

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Tear down KZG trusted setup after each test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Fix test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Prevent another trusted setup already loaded error during tests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
@fab-10 @macfarla @NickSneo
Add Holešky as predefined network name (hyperledger#5797)
fcd726f 
* Add Holešky testnet network name

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* CHANGELOG

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Add a fake KZG setup since Holesky define Cancun as future fork

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Tear down KZG trusted setup after each test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Fix test

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Prevent another trusted setup already loaded error during tests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fab-10 @jflo @macfarla @bgravenorst