Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tuweni-devp2p dependency #7980

Open
garyschulte opened this issue Dec 4, 2024 · 0 comments · May be fixed by #7989
Open

Remove tuweni-devp2p dependency #7980

garyschulte opened this issue Dec 4, 2024 · 0 comments · May be fixed by #7989
Assignees
Labels
dependencies peering techdebt maintenance, cleanup, refactoring, documentation

Comments

@garyschulte
Copy link
Contributor

Description

It appears the only requirement for tuweni:devp2p is the use of EthereumNodeRecord pojo( but kotlin) in DNS related discovery code. As we are trying to in-house several of the tuweni types, refactoring and bringing the node record type into besu should allow us to drop an additional code library dependency, specifically tuweni:devp2p

This should help with the move of Bytes and its subclasses into besu as well.

Acceptance Criteria

  • create and use a besu type for ENR in DNS discovery classes
  • remove the tuweni:devp2p dependency in besu
@garyschulte garyschulte added dependencies peering techdebt maintenance, cleanup, refactoring, documentation labels Dec 4, 2024
@usmansaleem usmansaleem linked a pull request Dec 5, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies peering techdebt maintenance, cleanup, refactoring, documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants