Reimplement EthereumNodeRecord for DNS discovery #7989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
macfarla
reviewed
Dec 5, 2024
| class EthereumNodeRecordTest { | ||
|
|
||
| @Test | ||
| void buildFromRLP() throws Exception { |
There was a problem hiding this comment.
worth adding some tests for error handling? udp / tcp port values?
There was a problem hiding this comment.
updated unit test and added additional test to cover error conditions.
...2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/dns/EthereumNodeRecordTest.java
Outdated
Show resolved
Hide resolved
...2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/dns/EthereumNodeRecordTest.java
Outdated
Show resolved
Hide resolved
| while (!input.isEndOfCurrentList()) { | ||
| var key = new String(input.readBytes().toArrayUnsafe(), StandardCharsets.UTF_8); | ||
| if (input.nextIsList()) { | ||
| // skip list as we currently don't need and support complex structures |
There was a problem hiding this comment.
Suggested change
| // skip list as we currently don't need and support complex structures | |
| // skip list as we currently don't need to support complex structures |
There was a problem hiding this comment.
modified this slightly.
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Reimplement EthereumNodeRecord to avoid dependency on tuweni-devp2p
Fixed Issue(s)
Fixes #7980
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests