Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist address and slot warmth in CREATE[2] calls. #1468

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Persist address and slot warmth in CREATE[2] calls. #1468

merged 3 commits into from
Oct 19, 2020

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Oct 17, 2020

The warm address/slot data was not returned to the calling messageFrame
for CREATE[2] calls as it was for CALL series calls.

Also, improve performance by using more efficient copy constructors and
reusing objects were relevant.

Addresses holiman/goevmlab#24

Signed-off-by: Danno Ferrin danno.ferrin@gmail.com

Changelog

@shemnon
Persist address ans slot warmth in CREATE[2] calls.
5dec663 
The warm address/slot data was not returned to the calling messageFrame
for CREATE[2] calls as it was for CALL series calls.

Also, improve performance by using more efficient copy constructors and
reusing objects were relevant.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
holiman
holiman approved these changes Oct 18, 2020
View reviewed changes
Copy link

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to fix the testcases found via fuzzing. Nothing new found yet

@holiman
Copy link

holiman commented Oct 19, 2020

Update: 28K tests executed, no issues found

AbdelStark
AbdelStark approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shemnon shemnon merged commit 43abf83 into hyperledger:master Oct 19, 2020
@timbeiko timbeiko added the RC Backport PRs that need to be backported to the latest RC branch. Remove after backport. label Oct 19, 2020
shemnon added a commit to shemnon/besu that referenced this pull request Oct 19, 2020
@shemnon
Persist address ans slot warmth in CREATE[2] calls. (hyperledger#1468)
20212d4 
The warm address/slot data was not returned to the calling messageFrame
for CREATE[2] calls as it was for CALL series calls.

Also, improve performance by using more efficient copy constructors and
reusing objects were relevant.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
(cherry picked from commit 43abf83)
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@shemnon shemnon mentioned this pull request Oct 19, 2020
Merged
1 task
shemnon added a commit that referenced this pull request Oct 20, 2020
@shemnon
Persist address ans slot warmth in CREATE[2] calls. (#1468)
23f3c28 
The warm address/slot data was not returned to the calling messageFrame
for CREATE[2] calls as it was for CALL series calls.

Also, improve performance by using more efficient copy constructors and
reusing objects were relevant.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
(cherry picked from commit 43abf83)
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@timbeiko timbeiko removed the RC Backport PRs that need to be backported to the latest RC branch. Remove after backport. label Oct 21, 2020
@shemnon shemnon deleted the eip2929create branch February 26, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelStark AbdelStark AbdelStark approved these changes

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shemnon @holiman @AbdelStark @timbeiko