Splitting up responsibilities of the JsonRpcMethodsFactory #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
…nto refactor-jsonrpc-factories
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Christopher Hare <chris.hare@consensys.net> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
…nto refactor-jsonrpc-factories
When setting the p2p port to zero and turning on UPNP nat an attempt is made to map port zero. This should actually map the opened port instead. The core logic is also now set up to throw an exception if a zero local port is requested. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Istanbul Mainnet block is 9,069,000. Update mainnet config. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
The IbftQueryService has been added to the Plugin-api, along with an implementation. This allows IBFT specific aspects of a block header to be queried (round number, and signers in block). Signed-off-by: Trent Mohay <trent.mohay@consensys.net> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
#154) Signed-off-by: Christopher Hare <chris.hare@consensys.net> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Christopher Hare <chris.hare@consensys.net> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Support the "--identity" flag. This adds a fifth field to the normally four part clientId, with the identity in the second position. For example, if the CLI flag "--identity PegaSysEng" were passed in the clientID reported by ethernodes would read `besu/PegaSysEng/v1.3.2/linux-x86_64/oracle_openjdk-java-11` Whereas without the flag it would just read `besu/v1.3.2/linux-x86_64/oracle_openjdk-java-11` Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
…or the release tomorrow and dont have jenkins & circle attempting to publish (#157) Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> Signed-off-by: Christopher Hare <chris.hare@consensys.net>
…nto refactor-jsonrpc-factories
|
Broken history |
This was referenced Feb 22, 2022
Closed
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
Added refs-openrpc.json to deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
JsonRpcMethodsFactory(currently there is an interface and a factory, unrelated to each other)Fixed Issue(s)