update Cava library to Tuweni Library #18
Conversation
Cava and Tuweni are the same thing but renamed when moved to Apache foundation Signed-off-by: Nicolas <nicolas.massart@consensys.net>
Vertex is linked from Orion in acceptance tests so removing it makes tests fail Signed-off-by: Nicolas <nicolas.massart@consensys.net>
NicolasMassart
requested review from
ajsutton,
shemnon,
RatanRSur and
AbdelStark
| @@ -54,7 +54,13 @@ dependencyManagement { | |||
|
|
|||
| dependency 'junit:junit:4.12' | |||
|
|
|||
| dependency 'net.consensys.cava:cava-toml:0.5.0' | |||
| dependencySet(group: 'org.apache.tuweni', version: '0.9.0-20190709195335') { | |||
There was a problem hiding this comment.
Is this a full release or a snapshot? The -201907... bit has me worried.
There was a problem hiding this comment.
This to me indicates a non-production release. And being an apache project it may not have had its release approved. This makes me nervous.
Is there a particular reason we need to go to the tuweni library?
There was a problem hiding this comment.
The Cava project is archived, I think this forces us to go to where the project lives now. I would prefer an incubating version over an archived one.
Binaries are all named after this scheme : https://bintray.com/tuweni/tuweni/tuweni
Also Besu is in the same incubation status at Hyperledger, it doesn't make it a project people can't use, does it?
There was a problem hiding this comment.
Incubation isn't the issue, the question is whether this is a stable release or a -SNAPSHOT. We'd much prefer a stable release of an archived project to a -SNAPSHOT release.
There was a problem hiding this comment.
Notably, the latest release on Tuweni's GitHub is 0.8.1: https://github.com/apache/incubator-tuweni/releases
* fix: misunderstanding name * lint: remove redundant white space
PR description
Cava and Tuweni are the same thing but renamed when moved to Apache foundation
Fixed Issue(s)
fixes PAN-3156