eth_feeHistory #2432

RatanRSur · 2021-06-14T22:37:13Z

The spec for this implementation is listed in the issue below.

Fixed Issue(s)

fixes #2430

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistory.java

...creation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockCreator.java

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte

suggestions re: arithmetic and input validation

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistory.java

.../test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistoryTest.java

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistory.java

garyschulte

LGTM, just need to address effectivePriorityFee for legacy transactions post-london

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java

garyschulte

🚢 (after unit tests)

...creation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockCreator.java

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte · 2021-06-21T20:57:11Z

ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/BlockDataGenerator.java

@@ -619,7 +620,7 @@ public KeyPair generateKeyPair() {
    private boolean hasTransactions = true;
    private TransactionType[] transactionTypes = TransactionType.values();
    private Optional<Address> coinbase = Optional.empty();
-    private Optional<Long> baseFee = Optional.empty();
+    private Optional<Optional<Long>> maybeBaseFee = Optional.empty();


Optional<Optional<Long>> ?

Yeah because we need a way to encode if the basefee is unspecified. This is important for knowing whether to use a default base fee or the optional.empty the caller gives explicitly to the builder.

...reum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTest.java

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistory.java

matkt · 2021-06-22T13:06:00Z

I'm just concerned about the performance of this API when blockcount == 500 on calaveras. I wanted to try and after 2 minutes and several thread blocked we have the result. I also wanted to test with a blockcount == 10 starting from the block 6400 and I had 23 seconds. These blocks are filled by transactions

What is the blockcount requested in the common case ?

RatanRSur · 2021-06-22T14:51:52Z

I think block counts of 500 would be very unusual but 10 sounds reasonable.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte · 2021-06-22T16:38:01Z

I think block counts of 500 would be very unusual but 10 sounds reasonable.

How about we silently map anything >10 to 10. We might fail some test cases in hive, but this seems like an acceptable tradeoff for now.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte

🚢

timbeiko mentioned this pull request Jun 15, 2021

add feeHistory spec ethereum/execution-specs#212

Merged

RatanRSur added 17 commits June 16, 2021 21:30

beginning

62dd31f

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

fee history class and other stuff

ec78644

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

get first 3 fields working

27a79f1

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

add a bunch of stuff to the failing test

e250c30

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

add headers

22dd003

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

spotless

dedf4dc

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

get all fields test working

b5a6470

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

0 for base fee

3f7ac5f

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

add extra base fee

97a147c

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

update names to latest spec

1470c40

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

test block count higher than chain head

7f61250

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

add test for all zeros

70fdcca

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

error on block too high

15ce6b5

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

spotless

8b3a7e0

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

get rpc spec test wired up and failing

4a4a354

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

fix tests

ad89e50

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

spotless

d0051dc

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur force-pushed the fee-history branch from 5ee1075 to d0051dc Compare June 17, 2021 02:32

RatanRSur added 4 commits June 16, 2021 21:41

sorting and comments

60b5184

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

remove redundant assignment

c55e7a9

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

fix transaction selector

760338f

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

make test presume 1559

b169d79

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur marked this pull request as ready for review June 17, 2021 03:37

RatanRSur changed the title ~~fee history~~ eth_feeHistory Jun 17, 2021

matkt requested changes Jun 17, 2021

View reviewed changes

matkt reviewed Jun 17, 2021

View reviewed changes

...creation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockCreator.java Outdated Show resolved Hide resolved

RatanRSur added 2 commits June 17, 2021 09:57

fix range errors

cfb06bc

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

switch to Immutable

253259f

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte requested changes Jun 17, 2021

View reviewed changes

RatanRSur added 2 commits June 17, 2021 14:32

test upper bound for block count

8aa77a6

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

cleanup

4aa9cc5

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte reviewed Jun 17, 2021

View reviewed changes

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistory.java Show resolved Hide resolved

garyschulte reviewed Jun 17, 2021

View reviewed changes

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistory.java Show resolved Hide resolved

garyschulte requested changes Jun 17, 2021

View reviewed changes

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java Outdated Show resolved Hide resolved

garyschulte approved these changes Jun 18, 2021

View reviewed changes

garyschulte requested changes Jun 18, 2021

View reviewed changes

...creation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockCreator.java Outdated Show resolved Hide resolved

RatanRSur added 4 commits June 21, 2021 09:31

Merge branch 'master' of github.com:hyperledger/besu into fee-history

07f5f71

fix reorg tests

ae2c951

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Merge branch 'master' of github.com:hyperledger/besu into fee-history

3afe531

fix tests

cc96aad

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

RatanRSur enabled auto-merge (squash) June 21, 2021 20:24

garyschulte requested changes Jun 21, 2021

View reviewed changes

fix epfpg calc

b07979c

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

matkt reviewed Jun 22, 2021

View reviewed changes

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistory.java Outdated Show resolved Hide resolved

RatanRSur added 3 commits June 22, 2021 09:53

fix lambda names

89cdd45

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

remove unnecessary check

a65895d

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

changelog

47de7f9

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte and others added 3 commits June 22, 2021 10:05

Merge branch 'master' into fee-history

ce02ef3

Merge branch 'master' of github.com:hyperledger/besu into fee-history

7e31430

update ref tests

a098f81

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

garyschulte approved these changes Jun 22, 2021

View reviewed changes

RatanRSur closed this Jun 22, 2021

auto-merge was automatically disabled June 22, 2021 18:13
Pull request was closed

garyschulte added the documentation Improvements or additions to documentation label Jun 24, 2021

bgravenorst mentioned this pull request Jul 16, 2021

Document eth_feeHistory API hyperledger/besu-docs#751

Closed

rolandtyler removed the documentation Improvements or additions to documentation label Apr 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eth_feeHistory #2432

eth_feeHistory #2432

RatanRSur commented Jun 14, 2021 •

edited

Loading

garyschulte left a comment

garyschulte left a comment

garyschulte left a comment •

edited

Loading

garyschulte Jun 21, 2021

RatanRSur Jun 22, 2021

matkt commented Jun 22, 2021

RatanRSur commented Jun 22, 2021

garyschulte commented Jun 22, 2021

garyschulte left a comment

eth_feeHistory #2432

eth_feeHistory #2432

Conversation

RatanRSur commented Jun 14, 2021 • edited Loading

Fixed Issue(s)

Changelog

garyschulte left a comment

Choose a reason for hiding this comment

garyschulte left a comment

Choose a reason for hiding this comment

garyschulte left a comment • edited Loading

Choose a reason for hiding this comment

garyschulte Jun 21, 2021

Choose a reason for hiding this comment

RatanRSur Jun 22, 2021

Choose a reason for hiding this comment

matkt commented Jun 22, 2021

RatanRSur commented Jun 22, 2021

garyschulte commented Jun 22, 2021

garyschulte left a comment

Choose a reason for hiding this comment

RatanRSur commented Jun 14, 2021 •

edited

Loading

garyschulte left a comment •

edited

Loading