Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate connect to self #3342

Merged
merged 5 commits into from
Jan 28, 2022

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Jan 28, 2022

Prevent connecting to self enode.

See #2689 and #3322

Changelog

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla requested a review from pinges January 28, 2022 05:12
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla enabled auto-merge (squash) January 28, 2022 07:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@macfarla macfarla merged commit 67adfbc into hyperledger:main Jan 28, 2022
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Feb 11, 2022
* don't allow connect to self

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
lucassaldanha pushed a commit to lucassaldanha/besu that referenced this pull request Feb 16, 2022
* don't allow connect to self

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
lucassaldanha pushed a commit to lucassaldanha/besu that referenced this pull request Feb 16, 2022
* don't allow connect to self

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
jflo pushed a commit that referenced this pull request Feb 16, 2022
* add a websocket max frame size configuration in support of nimbus EL/CL interop (#3379)
* Response streaming: stop on IO error and remove queue management (#3399)
* Queue management is removed, since it is not working at the moment,
and can cause deadlocks, will be reimplemented later if needed.
* Improve closing behavior of JsonResponseStreamer, and make clear it is managed bt the ObjectWriter (#3421)
* Add ec-curve parameter public key export/export-address subcommands (#3333)
* Eliminate connect to self (#3342)
* Refactor to async retrieve blocks, and change peer when retrying to get a block (#3326)
* Disable RocksDB TTL compactions (#3356)
* fix launcher issue (#3352)
* Handle null forkId gracefully (#3409)
* When asking for the forkId for the chain head sometimes we may return
null. In those cases return an empty list. (#3343)

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: fab-10 <91944855+fab-10@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Co-authored-by: matkt <karim.t2am@gmail.com>
Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com>
@macfarla macfarla deleted the eliminate-connect-to-self branch February 17, 2022 22:59
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* don't allow connect to self

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants