-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate connect to self #3342
Merged
macfarla
merged 5 commits into
hyperledger:main
from
macfarla:eliminate-connect-to-self
Jan 28, 2022
Merged
Eliminate connect to self #3342
macfarla
merged 5 commits into
hyperledger:main
from
macfarla:eliminate-connect-to-self
Jan 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
pinges
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Kudos, SonarCloud Quality Gate passed! |
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Feb 11, 2022
* don't allow connect to self Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
lucassaldanha
pushed a commit
to lucassaldanha/besu
that referenced
this pull request
Feb 16, 2022
* don't allow connect to self Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
lucassaldanha
pushed a commit
to lucassaldanha/besu
that referenced
this pull request
Feb 16, 2022
* don't allow connect to self Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
jflo
pushed a commit
that referenced
this pull request
Feb 16, 2022
* add a websocket max frame size configuration in support of nimbus EL/CL interop (#3379) * Response streaming: stop on IO error and remove queue management (#3399) * Queue management is removed, since it is not working at the moment, and can cause deadlocks, will be reimplemented later if needed. * Improve closing behavior of JsonResponseStreamer, and make clear it is managed bt the ObjectWriter (#3421) * Add ec-curve parameter public key export/export-address subcommands (#3333) * Eliminate connect to self (#3342) * Refactor to async retrieve blocks, and change peer when retrying to get a block (#3326) * Disable RocksDB TTL compactions (#3356) * fix launcher issue (#3352) * Handle null forkId gracefully (#3409) * When asking for the forkId for the chain head sometimes we may return null. In those cases return an empty list. (#3343) Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: fab-10 <91944855+fab-10@users.noreply.github.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: matkt <karim.t2am@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* don't allow connect to self Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent connecting to self enode.
See #2689 and #3322
Changelog