rename premerge fork to paris, keep premerge as an alias #3615
Conversation
|
|
||
| GenesisConfigFile parisOverAlias = | ||
| GenesisConfigFile.fromConfig( | ||
| "{\"config\":{\"parisBlock\":10,\"preMergeForkBlock\":11},\"baseFeePerGas\":\"0xa\"}"); |
There was a problem hiding this comment.
Change my mind: this should be an error not an override
There was a problem hiding this comment.
There are a number of Genesis files out for kiln and devnet5 that reference the prior fork name. The alias is a way to ease the friction of the change.
I am thinking we should drop it before we merge any of the long lived test nets, possibly before we release 22.1.3. But I would like to make the UX for testers a bit smoother in the interim.
There was a problem hiding this comment.
One or the other is fine. We did this with berlin and eip1559. But specifying both should be an error. If you went in to add Paris you should also remove preMergeFork
There was a problem hiding this comment.
Ah I gotcha. That makes sense. I thought you were referring to just having an alias 👍
| assertThatThrownBy(() -> dupeOptions.getParisBlockNumber()) | ||
| .isInstanceOf(RuntimeException.class); | ||
|
|
||
| // assert empty in neither are present: |
garyschulte
force-pushed
the
3608-paris-merge-fork
branch
from
edb3782 to
2811e62
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
…throw runtime Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
3608-paris-merge-fork
branch
from
2811e62 to
4522748
Compare
|
Kudos, SonarCloud Quality Gate passed! |
…#3615) * rename premerge fork to paris, keep premerge as an alias Signed-off-by: garyschulte <garyschulte@gmail.com>
…#3615) * rename premerge fork to paris, keep premerge as an alias Signed-off-by: garyschulte <garyschulte@gmail.com>
…#3615) * rename premerge fork to paris, keep premerge as an alias Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte garyschulte@gmail.com
PR description
rename the merge fork to
pariskeep
premergeas an alias for parisFixed Issue(s)
fixes #3608
Changelog