Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This makes some changes to how we onboard a new EthPeer into EthPeers #3945

Closed
wants to merge 24 commits into from
Closed

This makes some changes to how we onboard a new EthPeer into EthPeers #3945

wants to merge 24 commits into from

Conversation

pinges
Copy link
Contributor

@pinges pinges commented Jun 8, 2022

Signed-off-by: Stefan stefan.pingel@consensys.net

@pinges
first try
2c8c083 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2022

This pull request introduces 1 alert when merging 2c8c083 into 1c7c9ed - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

@pinges
fix some edgecases
6432696 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 12, 2022
View reviewed changes
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthPeers.java Outdated
}
preStatusExchangedPeers.remove(peerConnection.getPeer().getId());

Check failure

Code scanning / CodeQL

Type mismatch on container modification

Actual argument type 'Bytes' is incompatible with expected argument type 'PeerConnection'.
@lgtm-com
Copy link

lgtm-com bot commented Jun 12, 2022

This pull request introduces 1 alert when merging 6432696 into c3a222a - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

pinges added 2 commits June 12, 2022 22:14
@pinges
fix some edgecases
1a50619 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
fix some edgecases
40ceeda 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@lgtm-com
Copy link

lgtm-com bot commented Jun 12, 2022

This pull request introduces 1 alert when merging 40ceeda into c3a222a - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

@pinges
add more logging
2409ab4 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@lgtm-com
Copy link

lgtm-com bot commented Jun 12, 2022

This pull request introduces 1 alert when merging 2409ab4 into c3a222a - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

@mbaxter mbaxter mentioned this pull request Jun 13, 2022
Closed
@pinges
fix unit tests
411a64b 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2022

This pull request introduces 1 alert when merging 411a64b into e1d0a3d - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

pinges added 5 commits June 16, 2022 16:55
@pinges
fix unit tests
f1a2085 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
fix acc tests
f36f246 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
fix acc tests
c818283 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
fix acc tests
36cda04 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
revert a couple of commits
1b5f84e 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request introduces 1 alert when merging 1b5f84e into c0631cf - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

pinges added 2 commits June 16, 2022 20:33
@pinges
refix the unit tests
9d3a880 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
refix the unit tests
aa81982 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request introduces 1 alert when merging aa81982 into 2b42f6e - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

pinges added 7 commits June 18, 2022 15:40
@pinges
make sure the chainstate is reported and actioned on
c4adfc2 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
fix chain state test
ac2fac6 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
fix chain state test
161def4 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
fix LGTM
9b70900 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
undo last commit to see whether that caused that many tests to fail
3fe01a0 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
keep other connections a bit longer and check for the chain status fr…
8e684ac 
…om other EthPeers before requesting it

Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
do not disconnect too early
e635149 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
pinges added 4 commits June 20, 2022 14:30
@pinges
store xml files and try to get chain state later as well
4d56743 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
do not close connection if eth peer has not been removed from pre
0283da3 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
use the right connection for the prev
39654e4 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges
merge upstream
e746d97 
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@macfarla
Copy link
Contributor

closing this one in favour of #4001

@macfarla macfarla closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinges @macfarla