Add a new CLI option to limit the number of requests in a single RPC batch request #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
| @@ -86,6 +86,8 @@ public interface DefaultCommandValues { | |||
| int DEFAULT_P2P_PEER_LOWER_BOUND = 25; | |||
| /** The constant DEFAULT_HTTP_MAX_CONNECTIONS. */ | |||
| int DEFAULT_HTTP_MAX_CONNECTIONS = 80; | |||
| /** The constant DEFAULT_HTTP_MAX_BATCH_SIZE. */ | |||
| int DEFAULT_HTTP_MAX_BATCH_SIZE = 50; | |||
There was a problem hiding this comment.
Should mirror Geth and other clients at 1 IMO - users that leave this exposed by default will not want such a large batch size and those that need the functionality can track down this CLI option in the docs.
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
gfukushima
reviewed
Jan 20, 2023
| return JsonRpcExecutorHandler.handler(jsonRpcExecutor, tracer); | ||
| final JsonRpcExecutor jsonRpcExecutor, | ||
| final Tracer tracer, | ||
| final JsonRpcConfiguration configuration) { |
There was a problem hiding this comment.
nit: suggestion of variable name to follow the same pattern -> jsonRpcConfiguration
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
macfarla
approved these changes
Jan 22, 2023
macfarla
added
the
doc-change-required
1 task
alexandratran
removed
the
doc-change-required
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…batch request (hyperledger#4965) * Add option to limit requests in a single batch Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Change changelog Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Set default max batch size to one Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Update changelog Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Fix max rpc batch size for unit tests Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Change variable name Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…batch request (hyperledger#4965) * Add option to limit requests in a single batch Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Change changelog Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Set default max batch size to one Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Update changelog Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Fix max rpc batch size for unit tests Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Change variable name Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds a
--rpc-http-max-batch-sizeCLI option to restrict the maximum number of requests in a single RPC batch request.Default
50When
-1: unlimited - the current configuration.When number of requests in batch >
--rpc-http-max-batch-size:INVALID_PARAMand messageNumber of requests in batch exceeds --rpc-http-max-batch-size.Fixed Issue(s)
fixes #4951
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog