Refactor some transaction calculations #6150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clamp upfront gas calculations to uint256 max instead of throwing an exception. Fix related encoding changes and tests to validate. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
jflo
reviewed
Nov 9, 2023
.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetTransactionByHashTest.java
Outdated
Show resolved
Hide resolved
…nt-gas Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
shemnon
changed the title
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
…nt-gas Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
fab-10
approved these changes
Nov 28, 2023
…nt-gas Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
Refactor some transaction calculations, including moving upfront overflow checks from the constructor to the validator and optimizing some RLP calculations. Also fix all lint errors. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
Refactor some transaction calculations, including moving upfront overflow checks from the constructor to the validator and optimizing some RLP calculations. Also fix all lint errors. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
Refactor some transaction calculations, including moving upfront overflow checks from the constructor to the validator and optimizing some RLP calculations. Also fix all lint errors. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima
pushed a commit
to gfukushima/besu
that referenced
this pull request
Dec 15, 2023
Refactor some transaction calculations, including moving upfront overflow checks from the constructor to the validator and optimizing some RLP calculations. Also fix all lint errors. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some transaction calculations, including moving upfront
overflow checks from the constructor to the validator and optimizing
some RLP calculations. Also fix all lint errors.
PR description
Fixed Issue(s)