Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment out flaky part of acceptance test #6186

Merged
merged 1 commit into from
Nov 20, 2023
Merged

comment out flaky part of acceptance test #6186

merged 1 commit into from
Nov 20, 2023

Conversation

macfarla
Copy link
Contributor

this particular test is flaky. There are other tests for the same class that work more reliably.

Example of flaky fail -
https://app.circleci.com/pipelines/github/hyperledger/besu/25195/workflows/a5a40b6e-0f1d-4ac3-87e6-108bcce92b9e/jobs/164640

@macfarla
comment out flaky part of test
e048c3b 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla macfarla requested a review from atoulme November 20, 2023 05:50
@macfarla macfarla added the flake 60% of the time it works 100% of the time. label Nov 20, 2023
siladu
siladu approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit f01e4a2 into hyperledger:main Nov 20, 2023
19 checks passed
jflo pushed a commit to jflo/besu that referenced this pull request Nov 20, 2023
@macfarla @jflo
comment out flaky part of test (hyperledger#6186)
70fa9f7 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@macfarla macfarla deleted the otel-at-flaky branch December 1, 2023 03:52
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
@macfarla @jflo
comment out flaky part of test (hyperledger#6186)
d2c6322 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
@macfarla @gfukushima
comment out flaky part of test (hyperledger#6186)
73cb97b 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees
No one assigned
Labels
flake 60% of the time it works 100% of the time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @siladu