Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary PoS checkpoint methods and variables #6603

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

gfukushima
Copy link
Contributor

@gfukushima gfukushima commented Feb 22, 2024

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

This PR removes unnecessary checks and variables used to work around the latestValidAncestorDescendsFromTerminal from PoW, which has been removed by PR #4703

  • Test done:
  • Synced Sepolia successfully
  • Synced Goerli successfully
  • Synced Mainnet successfully

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima gfukushima changed the title remove unnecessary PoS checkpoint methods and variables Remove unnecessary PoS checkpoint methods and variables Feb 23, 2024
@gfukushima gfukushima marked this pull request as ready for review February 23, 2024 05:51
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfukushima gfukushima enabled auto-merge (squash) February 26, 2024 22:58
@gfukushima gfukushima merged commit 3e36b2c into hyperledger:main Feb 26, 2024
55 checks passed
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 28, 2024
…6603)

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…6603)

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…6603)

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
…6603)

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants