Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Besu command test split #6644

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Besu command test split #6644

merged 2 commits into from
Feb 29, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 29, 2024 •
edited
Loading

Refs #6428

  • split out some tests into separate test classes
  • Also use tempDir for the dataDirOptionMustBeUsed test to avoid leaving behind besu/VERSION_METADATA.json file

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

@macfarla
refactored some BesuCommandTests into separate test classes
503cf39 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
merge
bae0d61 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Gabriel-Trintinalia
Gabriel-Trintinalia approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loved it! LGTM

@macfarla macfarla merged commit 2abb4c1 into hyperledger:main Feb 29, 2024
62 of 63 checks passed
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
refactored some BesuCommandTests into separate test classes (hyperled…
f021d5c 
…ger#6644)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
refactored some BesuCommandTests into separate test classes (hyperled…
ee2dc51 
…ger#6644)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
@macfarla macfarla deleted the besu-command-test-split branch April 17, 2024 01:13
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@macfarla @matthew1001
refactored some BesuCommandTests into separate test classes (hyperled…
a3476a9 
…ger#6644)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel-Trintinalia Gabriel-Trintinalia Gabriel-Trintinalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @Gabriel-Trintinalia