Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] - Update gradle build to invoke int test compile task on assemble task #6688

Merged

Conversation

usmansaleem
Copy link
Member

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

The assemble task has been modified to additionally depends on compileIntegrationTestJava so that any compilation issues are reported earlier locally and in CI.

Fixed Issue(s)

Fixes #6670

Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem requested a review from macfarla March 7, 2024 03:10
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@usmansaleem usmansaleem enabled auto-merge (squash) March 7, 2024 03:20
@usmansaleem usmansaleem disabled auto-merge March 7, 2024 03:20
@usmansaleem usmansaleem enabled auto-merge (squash) March 7, 2024 03:21
@usmansaleem usmansaleem merged commit 5b230e5 into hyperledger:main Mar 7, 2024
59 of 63 checks passed
jflo pushed a commit to jflo/besu that referenced this pull request Mar 8, 2024
…t compile task (hyperledger#6688)

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@usmansaleem usmansaleem deleted the int_test_compile_assemble branch March 13, 2024 23:10
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…t compile task (hyperledger#6688)

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…t compile task (hyperledger#6688)

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
…t compile task (hyperledger#6688)

Signed-off-by: Usman Saleem <usman@usmans.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compileTestJava does not cover integration tests
2 participants