Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pruned chain history in peer validators #6698

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Mar 7, 2024

PR description

Change the behavior of peer block validator to allow block absence to be tolerated for some rules, specifically DaoForkPeerValidator, in support of:

Fixed Issue(s)

@garyschulte garyschulte force-pushed the feature/support-peers-with-pruned-history branch 2 times, most recently from 8589e56 to d414713 Compare March 8, 2024 20:35
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment on log message. worth a change log entry?

…s with pruned chain history

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the feature/support-peers-with-pruned-history branch from d414713 to f768744 Compare March 12, 2024 22:19
…eervalidation/AbstractPeerBlockValidator.java

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte enabled auto-merge (squash) March 12, 2024 22:21
@macfarla macfarla disabled auto-merge March 13, 2024 01:19
@macfarla macfarla merged commit c39ca6d into hyperledger:main Mar 13, 2024
42 checks passed
@garyschulte garyschulte deleted the feature/support-peers-with-pruned-history branch March 13, 2024 16:56
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* dao fork block presence is optional in peer validator to support peers with pruned chain history

Signed-off-by: garyschulte <garyschulte@gmail.com>

* Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>

---------

Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* dao fork block presence is optional in peer validator to support peers with pruned chain history

Signed-off-by: garyschulte <garyschulte@gmail.com>

* Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>

---------

Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
* dao fork block presence is optional in peer validator to support peers with pruned chain history

Signed-off-by: garyschulte <garyschulte@gmail.com>

* Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>

---------

Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants