-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pruned chain history in peer validators #6698
Merged
macfarla
merged 3 commits into
hyperledger:main
from
garyschulte:feature/support-peers-with-pruned-history
Mar 13, 2024
Merged
Support pruned chain history in peer validators #6698
macfarla
merged 3 commits into
hyperledger:main
from
garyschulte:feature/support-peers-with-pruned-history
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
feature/support-peers-with-pruned-history
branch
2 times, most recently
from
March 8, 2024 20:35
8589e56
to
d414713
Compare
macfarla
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment on log message. worth a change log entry?
...c/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java
Outdated
Show resolved
Hide resolved
…s with pruned chain history Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/support-peers-with-pruned-history
branch
from
March 12, 2024 22:19
d414713
to
f768744
Compare
…eervalidation/AbstractPeerBlockValidator.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* dao fork block presence is optional in peer validator to support peers with pruned chain history Signed-off-by: garyschulte <garyschulte@gmail.com> * Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* dao fork block presence is optional in peer validator to support peers with pruned chain history Signed-off-by: garyschulte <garyschulte@gmail.com> * Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* dao fork block presence is optional in peer validator to support peers with pruned chain history Signed-off-by: garyschulte <garyschulte@gmail.com> * Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Change the behavior of peer block validator to allow block absence to be tolerated for some rules, specifically DaoForkPeerValidator, in support of:
Fixed Issue(s)