Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Move potentially spammy peer discovery warn log to debug #6728

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Mar 14, 2024

For one user, this log was appearing every couple of seconds.

We determined that it shouldn't affect the peers required for the node to function therefore there's potentially nothing to act on WARN level is too high.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu changed the title Move potentially spammy warn log to debug Move potentially spammy peer discovery warn log to debug Mar 14, 2024
@siladu siladu changed the title Move potentially spammy peer discovery warn log to debug [Minor] Move potentially spammy peer discovery warn log to debug Mar 14, 2024
@siladu siladu changed the title [Minor] Move potentially spammy peer discovery warn log to debug [MINOR] Move potentially spammy peer discovery warn log to debug Mar 14, 2024
@siladu siladu enabled auto-merge (squash) March 14, 2024 05:23
@siladu siladu merged commit 6dd3c84 into hyperledger:main Mar 14, 2024
42 checks passed
@siladu siladu deleted the discovery-log-debug branch March 14, 2024 06:07
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…#6728)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
…#6728)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
…#6728)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants