PR Annotations removed #6735
Merged
PR Annotations removed #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Gha pr annot
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Gha pr annot
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla
reviewed
Mar 14, 2024
| @@ -108,12 +124,11 @@ jobs: | |||
| - name: run unit tests | |||
| id: unitTest | |||
| run: ./gradlew $GRADLEW_UNIT_TEST_ARGS | |||
| - name: Publish Test Report | |||
| uses: mikepenz/action-junit-report@5f47764eec0e1c1f19f40c8e60a5ba47e47015c5 | |||
| if: success() || failure() # always run even if the build step fails | |||
There was a problem hiding this comment.
so Publish Test Report doesn't happen any more?
There was a problem hiding this comment.
correct. annotating the PR requires write access to the repository that the PR lives in, which is the targeted fork. If we want to allow this, we would need to switch the event type back to pull_request_target which would then run in the context of the targeted fork, using the version of the workflow defined there.
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* pull_req instead of target * updates template to put description first * compensate for changes to versioning on interim builds --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* pull_req instead of target * updates template to put description first * compensate for changes to versioning on interim builds --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* pull_req instead of target * updates template to put description first * compensate for changes to versioning on interim builds --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Removes annotation of failed tests onto pr, since we have to run them before review anyway.
Updates nightly release with a single artifact.
Updates PR template order
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests