Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filtered out the noisy Invalid Trace log messages #6825

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

macfarla
Copy link
Contributor

PR description

Added a filter for the"Invalid TraceId in B3 header" log

Fixed Issue(s)

Fixes #6440

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

Node where I added this config after a short time - number stays same

sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-control:~$ grep -c B3Prop /var/log/besu/besu.log
27
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-control:~$ grep -c B3Prop /var/log/besu/besu.log
27
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-control:~$ grep -c B3Prop /var/log/besu/besu.log
27
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-control:~$ grep -c B3Prop /var/log/besu/besu.log
27
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-control:~$ grep -c B3Prop /var/log/besu/besu.log
27
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-control:~$ grep -c B3Prop /var/log/besu/besu.log
27

Node without this config - number go up


sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-test-6823:~$ grep -c B3Prop /var/log/besu/besu.log
961
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-test-6823:~$ grep -c B3Prop /var/log/besu/besu.log
962
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-test-6823:~$ grep -c B3Prop /var/log/besu/besu.log
964
sallymacfarlane@dev-elc-besu-teku-sepolia-dev-sally-test-6823:~$ grep -c B3Prop /var/log/besu/besu.log
1313

@fab-10
Copy link
Contributor

fab-10 commented Mar 27, 2024

should the log be at TRACE level in the code?

@macfarla
Copy link
Contributor Author

should the log be at TRACE level in the code?

I did the same as we've done for noisy DNS messages etc. if you want to see the logs you can just take this out of your log4j config

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) April 8, 2024 08:04
@macfarla macfarla merged commit 6208f8f into hyperledger:main Apr 8, 2024
42 checks passed
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
@macfarla macfarla deleted the b3prop-log-nope branch April 17, 2024 01:01
macfarla added a commit to macfarla/besu that referenced this pull request Apr 26, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid span context noisy logging
3 participants