fix: Use HttpRequest authority instead of host #6879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use authority method to determine the host name from header instead of using deprecated host method Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
macfarla
reviewed
Apr 4, 2024
| }); | ||
| }); | ||
| testContext.awaitCompletion(VERTX_AWAIT_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS); | ||
| assertThat(testContext.awaitCompletion(VERTX_AWAIT_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS)) | ||
| .isTrue(); |
There was a problem hiding this comment.
@usmansaleem is this what you mean by the test needing fixing? there was no assertion before?
There was a problem hiding this comment.
@macfarla correct, from L220 to L232 as well.
Signed-off-by: Usman Saleem <usman@usmans.info>
jflo
approved these changes
Apr 4, 2024
Signed-off-by: Usman Saleem <usman@usmans.info>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Use HttpRequest authority method to determine the hostname from header instead of using deprecated host method Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Use HttpRequest authority method to determine the hostname from header instead of using deprecated host method Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: amsmota <antonio.mota@citi.com>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Apr 26, 2024
Use HttpRequest authority method to determine the hostname from header instead of using deprecated host method Signed-off-by: Usman Saleem <usman@usmans.info>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
Use HttpRequest authority method to determine the hostname from header instead of using deprecated host method Signed-off-by: Usman Saleem <usman@usmans.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
fix: Use HttpRequest authority instead of host.
Fixed Issue(s)
Fixes #6878
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests