Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block import progress logging: add peer count #6911

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Block import progress logging: add peer count #6911

merged 3 commits into from
Apr 9, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Apr 9, 2024

PR description

Add peer count to info level log

Fixed Issue(s)

Fixes #6910

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
add peer count
4689261 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
siladu
siladu approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) April 9, 2024 02:28
@macfarla macfarla merged commit 5ae2823 into hyperledger:main Apr 9, 2024
42 checks passed
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
add peer count (hyperledger#6911)
45ed842 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
add peer count (hyperledger#6911)
fe2e308 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
macfarla added a commit to macfarla/besu that referenced this pull request Apr 26, 2024
@macfarla
add peer count (hyperledger#6911)
dd70391 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@macfarla @matthew1001
add peer count (hyperledger#6911)
ba32177 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla deleted the add-peer-count-initial-sync branch July 16, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add peer count to initial sync block import log
3 participants
@macfarla @jframe @siladu