Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOGGING] snap pipeline errors and peer reputation #6924

Merged
merged 16 commits into from
May 8, 2024
Merged

[LOGGING] snap pipeline errors and peer reputation #6924

merged 16 commits into from
May 8, 2024

Conversation

gfukushima
Copy link
Contributor

@gfukushima gfukushima commented Apr 10, 2024 •
edited by macfarla
Loading

PR description

  • Log any possible throwables we're getting up on snap requests
  • also changes from Improve Peer Logging #6831 - log peer as part of peer reputation registerX()

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@gfukushima
add logs for snap errors
1f23f49 
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima
Merge branch 'main' into snap-pipeline-errors-logged
bb3d707
@gfukushima
add logs for requests that are returning with errors
7260f66 
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima
spotless
b07d241 
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima gfukushima marked this pull request as ready for review April 11, 2024 10:14
macfarla
macfarla previously approved these changes Apr 12, 2024
View reviewed changes
@macfarla
Copy link
Contributor

maybe we want to throttle this, depending on how spammy it is?

@macfarla
Copy link
Contributor

going to test this on some nodes and see how spammy it is

macfarla added a commit to pinges/besu that referenced this pull request Apr 12, 2024
@macfarla
extra logging from hyperledger#6924
de6899f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla self-assigned this Apr 24, 2024
macfarla and others added 4 commits April 29, 2024 12:44
@macfarla
turn down the logging
6e37d3b 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@jframe @macfarla
transaction message sender logging
4819307 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@macfarla
log peer with peer reputation event
e56572c 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into snap-pipeline…
3acc004 
…-errors-logged
@macfarla
Copy link
Contributor

combined this with changes from #6831

@macfarla macfarla changed the title Snap pipeline errors logged [LOGGING] snap pipeline errors and peer reputation Apr 29, 2024
@macfarla
Copy link
Contributor

going to test this on some nodes and see how spammy it is

too spammy at info level. changed to debug.

@macfarla
formatting
853fef4 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla mentioned this pull request Apr 29, 2024
Closed
8 tasks
@macfarla macfarla dismissed their stale review April 29, 2024 06:28

PR has changed

garyschulte
garyschulte approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@macfarla macfarla enabled auto-merge (squash) May 1, 2024 02:03
@macfarla macfarla merged commit 8601438 into hyperledger:main May 8, 2024
42 checks passed
jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
@gfukushima @macfarla
@jframe @jflo
[LOGGING] snap pipeline errors and peer reputation (hyperledger#6924)
fe4bee5 
* add logs for snap errors

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* add logs for requests that are returning with errors

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* spotless

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* turn down the logging

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* transaction message sender logging

Signed-off-by: Jason Frame <jason.frame@consensys.net>

* log peer with peer reputation event

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* formatting

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@gfukushima @macfarla
@jframe @matthew1001
[LOGGING] snap pipeline errors and peer reputation (hyperledger#6924)
eda489b 
* add logs for snap errors

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* add logs for requests that are returning with errors

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* spotless

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* turn down the logging

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* transaction message sender logging

Signed-off-by: Jason Frame <jason.frame@consensys.net>

* log peer with peer reputation event

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* formatting

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
@gfukushima @macfarla
@jframe @jflo
[LOGGING] snap pipeline errors and peer reputation (hyperledger#6924)
a5375a6 
* add logs for snap errors

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* add logs for requests that are returning with errors

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* spotless

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* turn down the logging

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* transaction message sender logging

Signed-off-by: Jason Frame <jason.frame@consensys.net>

* log peer with peer reputation event

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* formatting

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

@macfarla macfarla macfarla left review comments

Assignees

@macfarla macfarla

Labels
logging peering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gfukushima @macfarla @garyschulte @jframe