Fix named network default disabled for downgrade protection #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement comparable for VersionMetadata, add explicit coverage Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/disable-downgrade-protection-for-named-networks
branch
from
7800a08 to
52b779e
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
|
LGTM 🚢 Cannot provide approval |
Signed-off-by: garyschulte <garyschulte@gmail.com>
macfarla
approved these changes
Apr 14, 2024
garyschulte
deleted the
bugfix/disable-downgrade-protection-for-named-networks
branch
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…ger#6943) * fix default disabled for downgrade protection on named networks implement comparable for VersionMetadata, add explicit coverage Signed-off-by: garyschulte <garyschulte@gmail.com> * test method rename Signed-off-by: garyschulte <garyschulte@gmail.com> * remove errant comment Signed-off-by: garyschulte <garyschulte@gmail.com> * do not use static version metadata, to facilitate unit tests Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…ger#6943) * fix default disabled for downgrade protection on named networks implement comparable for VersionMetadata, add explicit coverage Signed-off-by: garyschulte <garyschulte@gmail.com> * test method rename Signed-off-by: garyschulte <garyschulte@gmail.com> * remove errant comment Signed-off-by: garyschulte <garyschulte@gmail.com> * do not use static version metadata, to facilitate unit tests Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Apr 26, 2024
…ger#6943) * fix default disabled for downgrade protection on named networks implement comparable for VersionMetadata, add explicit coverage Signed-off-by: garyschulte <garyschulte@gmail.com> * test method rename Signed-off-by: garyschulte <garyschulte@gmail.com> * remove errant comment Signed-off-by: garyschulte <garyschulte@gmail.com> * do not use static version metadata, to facilitate unit tests Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…ger#6943) * fix default disabled for downgrade protection on named networks implement comparable for VersionMetadata, add explicit coverage Signed-off-by: garyschulte <garyschulte@gmail.com> * test method rename Signed-off-by: garyschulte <garyschulte@gmail.com> * remove errant comment Signed-off-by: garyschulte <garyschulte@gmail.com> * do not use static version metadata, to facilitate unit tests Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Address downgrade default for named networks. Previously the check for named network was only considering command line params, and not toml config files.
Also implemented Comparable on VersionMetadata, and added explicit version test cases for a variety of build versions.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests