Implement System Calls #7263

Gabriel-Trintinalia · 2024-06-25T23:59:39Z

PR description

Introduces system calls - ( a call to CONTRACT_ADDRESS as SYSTEM_ADDRESS). This is a system operation and therefore:
- the call must be executed to completion
- the call does not count against the block’s gas limit
- the call does not follow the EIP-1559 burn semantics - no value should be transferred as part of the call
- if no code exists at CONTRACT_ADDRESS, the call must fail silently
Changes withdrawalRequestProcessor to perform a system call instead of directly manipulating storage.

Fixed Issue(s)

fixes #6918
fixes #7259

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

lucassaldanha

It seems to be on the right direction. Just need some tests :)

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SystemCallProcessor.java

...reum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/RequestProcessor.java

lucassaldanha · 2024-06-26T00:22:29Z

...src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/WithdrawalRequestProcessor.java

 public class WithdrawalRequestProcessor implements RequestProcessor {
+  private static final Address WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS =


One thing we need to consider is to parameterize this address. Probably a separate PR though (not sure if we have a ticket for it somewhere).

Parameterize it (i.e. can be changed at runtime) or Configure it (can be set once at startup)?

Agree with the later. Could entertain the former, but feels like yagni.

Agreed with the later - out of the scope of this PR. Created issue: #7288

...src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/WithdrawalRequestProcessor.java

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SystemCallProcessor.java

jflo

Some clarifying and logging suggestions, agree with Lucas re: test coverage.

...rc/main/java/org/hyperledger/besu/ethereum/mainnet/requests/RequestProcessorCoordinator.java

jflo · 2024-06-27T19:17:48Z

...src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/WithdrawalRequestProcessor.java

 public class WithdrawalRequestProcessor implements RequestProcessor {
+  private static final Address WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS =


Parameterize it (i.e. can be changed at runtime) or Configure it (can be set once at startup)?

Agree with the later. Could entertain the former, but feels like yagni.

jflo · 2024-06-27T19:19:37Z

...src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/WithdrawalRequestProcessor.java

+
+    WorldUpdater updater = mutableWorldState.updater();
+    if (updater.get(WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS) == null) {
+      return Optional.empty();


This is a pretty big missed assumption, I think it warrants at least an error log.

We will get this with every processed block if we log it. However, that may be worth repeating every 12 seconds, or blow up the log of a poorly constructed test network.

Probably what we want since it's a severe failure?

I'd go further than just an error log. If we don't have the address, we can't properly process blocks. So it is a critical error. I'd say exit with an error code. I don't think this is an error we would be able to recover from.

It shouldn't ever happen anyway.

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SystemCallProcessor.java

…net/SystemCallProcessor.java Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

…net/SystemCallProcessor.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

shemnon

I'm gonna put a block on this one. EEST tests do not fill with this PR.

I get this error from the t8n server when runnning any of the fill commands:

{"error":"System call address 0x00a3ca265ebcb825b45f985a16cefb49958ce017 is not deployed","stacktrace":"java.lang.RuntimeException: System call address 0x00a3ca265ebcb825b45f985a16cefb49958ce017 is not deployed at org.hyperledger.besu.ethereum.mainnet.requests.AbstractSystemCallRequestProcessor.process(AbstractSystemCallRequestProcessor.java:50) at org.hyperledger.besu.ethereum.mainnet.requests.RequestProcessorCoordinator.process(RequestProcessorCoordinator.java:43) at org.hyperledger.besu.evmtool.T8nExecutor.runTest(T8nExecutor.java:524) at org.hyperledger.besu.evmtool.T8nServerSubCommand.handleT8nRequest(T8nServerSubCommand.java:240) at org.hyperledger.besu.evmtool.T8nServerSubCommand.handle(T8nServerSubCommand.java:139) at org.hyperledger.besu.evmtool.T8nServerSubCommand.lambda$run$0(T8nServerSubCommand.java:122) at io.vertx.core.impl.future.FutureImpl$1.onSuccess(FutureImpl.java:91) at io.vertx.core.impl.future.FutureBase.lambda$emitSuccess$0(FutureBase.java:60) at io.vertx.core.impl.ContextImpl.execute(ContextImpl.java:298) at io.vertx.core.impl.DuplicatedContext.execute(DuplicatedContext.java:169) at io.vertx.core.impl.future.FutureBase.emitSuccess(FutureBase.java:57) at io.vertx.core.impl.future.FutureImpl.tryComplete(FutureImpl.java:259) at io.vertx.core.http.impl.HttpEventHandler.handleEnd(HttpEventHandler.java:79) at io.vertx.core.http.impl.Http1xServerRequest.handleEnd(Http1xServerRequest.java:592) at io.vertx.core.impl.ContextImpl.execute(ContextImpl.java:313) at io.vertx.core.impl.DuplicatedContext.execute(DuplicatedContext.java:159) at io.vertx.core.http.impl.Http1xServerConnection.onEnd(Http1xServerConnection.java:215) at io.vertx.core.http.impl.Http1xServerConnection.onContent(Http1xServerConnection.java:206) at io.vertx.core.http.impl.Http1xServerConnection.handleOther(Http1xServerConnection.java:189) at io.vertx.core.http.impl.Http1xServerConnection.handleMessage(Http1xServerConnection.java:176) at io.vertx.core.net.impl.ConnectionBase.read(ConnectionBase.java:159) at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:153) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:93) at io.netty.handler.codec.http.websocketx.extensions.WebSocketServerExtensionHandler.channelRead(WebSocketServerExtensionHandler.java:87) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1407) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:918) at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:994) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1583) "}

If the system address is not deployed, we skip the processing. This will break L2s and test networks that don't deploy these system contracts.

shemnon · 2024-07-03T21:51:29Z

Also from an EEST fill...

tests/prague/eip7002_el_triggerable_withdrawals/test_withdrawal_requests.py::test_withdrawal_requests[fork_Prague-blockchain_test-multiple_block_above_max_withdrawal_requests_from_eoa] FAILED [1174/1238]
tests/prague/eip7002_el_triggerable_withdrawals/test_withdrawal_requests.py::test_withdrawal_requests[fork_Prague-blockchain_test_hive-multiple_block_above_max_withdrawal_requests_from_eoa] FAILED [1196/1238]

Is that blocking for this PR? Is it intended this should work as a follow on from this PR?

.../java/org/hyperledger/besu/ethereum/mainnet/requests/AbstractSystemCallRequestProcessor.java

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

…intinalia/besu into implement-system-call

Gabriel-Trintinalia · 2024-07-04T00:19:34Z

Also from an EEST fill...

tests/prague/eip7002_el_triggerable_withdrawals/test_withdrawal_requests.py::test_withdrawal_requests[fork_Prague-blockchain_test-multiple_block_above_max_withdrawal_requests_from_eoa] FAILED [1174/1238]
tests/prague/eip7002_el_triggerable_withdrawals/test_withdrawal_requests.py::test_withdrawal_requests[fork_Prague-blockchain_test_hive-multiple_block_above_max_withdrawal_requests_from_eoa] FAILED [1196/1238]

Is that blocking for this PR? Is it intended this should work as a follow on from this PR?

@shemnon This PR is intended to be a drop-in replacement for WithdrawalRequestContractHelper. It should not fix/break any tests

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* EIP 7702 first draft Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added CHANGELOG.md entry Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * bug fixes, added first tests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * container verify GitHub workflow (#7239) Container verification step in release process automated with the container verify GitHub workflow. New workflow is triggered at the end of the release workflow which will check the release container images starts successfully. Verification test only checks container starts and reach the Ethereum main loop Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Investigate chain halts when syncing (#7162) Fix some reasons for chain download halts when syncing Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Check for EOFCreate subcontainer rules (#7232) Check and test for the unused container rule, and only returncontract targets can have truncated data rule. Also test the other subcontainer rules in unit tests. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Remove deprecation message for `--Xp2p-peer-lower-bound` (#7247) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * less invasive code injection approach Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing java doc & fixed test Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added (currently non-working) acceptance test, some bug fixes in the transaction validation and tx pool logic Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix spotless Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updated acceptance test, still not working, newPayload request seems to be necessary before final fork choice update Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * use correct world state to inject temporary code, inject code in existing accounts as well Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * renamed test service to prague, because the engine versions used are only available in the prague hard fork Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed acceptance test, some bug fixes if authorized account does not yet exist Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add build version option to prefix git hash with custom version property (#7222) * Add build version option to prefix git hash with custom version property * Refactor to make appending the git hash a boolean property. Include a commented-out example of how to use the properties in the gradle file Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Handle invalid snap getTrieNode requests with empty paths gracefully (#7221) Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix typos in CHANGELOG (#7226) Signed-off-by: Ties <71668189+TiesD@users.noreply.github.com> Co-authored-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * feat: Add network option for LUKSO Mainnet (#7223) * Add option for LUKSO network Signed-off-by: Wolmin <lamonos123@gmail.com> * Add tests for LUKSO Signed-off-by: Wolmin <lamonos123@gmail.com> * Apply spotless Signed-off-by: Wolmin <lamonos123@gmail.com> * Add changelog entry Signed-off-by: Wolmin <lamonos123@gmail.com> * Fix duplicate func Signed-off-by: Wolmin <lamonos123@gmail.com> * Fix changelog Signed-off-by: Wolmin <lamonos123@gmail.com> * Add bootnodes to genesis Signed-off-by: Wolmin <lamonos123@gmail.com> --------- Signed-off-by: Wolmin <lamonos123@gmail.com> Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update Docker base image to Ubuntu 24.04 (#7251) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Reconfigure how Protocol Specs are created WRT EVM condiguration (#7245) Make the max code size and max initcode size a part of the EVM configuration. As part of the change we need to move the tasks CodeFactory once handled as a static class and move it into the EVM. This has a nice follow on effect that we don't need to pass in max EOF versions or max code sizes anymore. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Fix the wrong 'Identifier' and 'Synchronizer' usage (#7252) * fix the synchronizer usage Signed-off-by: Leni <leniram159@gmail.com> * fix Identifier usage Signed-off-by: Leni <leniram159@gmail.com> --------- Signed-off-by: Leni <leniram159@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Fix flaky SECP256R1 test (#7249) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * update to work with the new max retries value (#7253) Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Temporary CancunEOF fork for EOF testing. (#7227) Add Genesis ("CancunEOFTime") and reference test ("CancunEOF") support for a temporary Cancun+EOF fork, in anticipation of potential devnets. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed bug introduced through merge of main, made acceptance test easier to understand Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing java docs Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * removed unnecessary tag Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * make encodeSingleSetCode public again Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Snapserver responses to return at least one response (#7190) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * copy setCodeTransactionPayloads as well Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed bug during tests with forrest db Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Snapserver GetTrieNodes request to handle short hash for storage (#7264) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * javadoc: Adding javadoc for ethstats module (#7269) * javadoc: Adding javadoc for ethstats module --------- Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Fix javadoc for ethereum:core top level package (#7270) * javadoc - Apply javadoc to ethereum core top level package --------- Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Disable Flaky tests - permissioning (#7256) * disable some flaky tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * correct name for test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * disable some flaky tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add bootnodes to the maintained peer list (#7257) * Add bootnodes to the maintained peer list Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update unit tests Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Add entry in changelog Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Tweak unit test Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Refactor to keep common steps the same for both cases Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Add debug log, call sanitizePeers() only once Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Fix javadoc for ethereum api module, graphql package (#7272) * javadoc - Adding missing javadocs ethereum:api graphql package Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * T8n support for isStateTest and empty accounts (#7275) Update t8n executor to support new isStateTest env flag that will disable extra-transactional processing such as block rewards and beacon root. Also, make sure such extra-transactional commits don't create empty accounts. Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Promote storage x-trie-log subcommand to trie-log (#7278) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Evm tool readme update (#7274) * update paths to binary. update docker build to use java 21 * updated suggested jdk --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * javadoc - Add missing javadoc for evmtool module (#7277) Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Rename ValidatorPublicKey to ValidatorPubKey (#7280) Adapt to EIP-7002 name change for validator public key in all places. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add info-level diagnostic logs to aid with resolving stalled BFT chains (#7271) * Add info-level diagnostic logs to aid with resolving stalled BFT chains Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Add javadoc Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update EIP-2935 contract (#7281) Use the updated contract and address for EIP-2539. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add evmtool compability, fixing bugs related to sender recovery of 7702 txs and handling authorizations to empty accounts Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Deeper tracing of self-destructed accounts (#7284) Consider previously self-destructed accounts when creating accounts. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * next release version after 24.7.0 (#7285) Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add experimental `--Xsnapsync-bft-enabled` which enables snap sync for BFT chains (#7140) * Create a BFT-specific pivot block handler Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Change visibility Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Refactor sync-peer-count internal variable to match name, add experimental flag to enabled snap + BFT Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Merge with main Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix uppercase Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Address synchronization issue with trie pruning. Create BFT-specific account range handler. Add pipeline name and logs Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Remove debug log Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * fixing snapsync for empty state Signed-off-by: Karim Taam <karim.t2am@gmail.com> * Don't queue up events we can't handle Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix timing window where a validator with an empty data dir sometimes falls back to full sync if peer status isn't received quickly enough Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Remove BFT-specific account request class. Not needed Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Refactor some more 'fast' sync variables that are common to all pivot-based sync types Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * In FULL sync mode, disable bonsai-limit-trie-logs-enabled instead of failing to start Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Add javadoc comments, clarify overriding bonsai-limit-trie-logs-enabled Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Add BFT pivot block selector tests Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix failure error message Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Remove the unnamed Pipe constructor and update tests to set a pipe name Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Revert some info logs back to debug given the feedback on noise in the logs syncing with holesky Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Refactor fastSyncPivotDistance to syncPivotDistance Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Incomplete refactoring Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update BFT event queueing tests Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Event queue test fixes Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Remove automatic setting of bonsai-limit-trie-logs-enabled to false if sync-mode = FULL (moving to another PR) Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Turn off CicleCI for Besu (#7291) All the CI jobs run in GitHub actions and Circle CI it no longer needed in Besu project Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Check for snap server (#6609) * EthPeer add isServingSnap to be able to make sure that we have enough snap servers connected when we are snap syncing Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Implement System Calls (#7263) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * wrap WorldUpdater inside a WorldUpdaterService to inject the authorized code whenever needed Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update limit trie logs validation message for sync-mode=FULL (#7279) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Execute requests before block persist (#7295) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed MainnetTransactionProcessor retrieval of correctn `to` account with injected code, fixed code injection Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * only first authorization is accepted, all the following ones are ignored Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * don't cache account with empty code Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * revert wrapping of world updater, as its `updater()` method creates a type of nesting that is not compatible with wrapping it. Instead a service is injected in the world updater to inject the code into the authorized accounts Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Fixed outdated tech redirect link. (#7297) * fix wiki link Signed-off-by: Snazzy <snazzysam933@gmail.com> * fix format Signed-off-by: Snazzy <snazzysam933@gmail.com> * change knownHash Signed-off-by: Snazzy <snazzysam933@gmail.com> --------- Signed-off-by: Snazzy <snazzysam933@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Increment private nonce even if transaction failed. (#6593) Increment private nonce even if transaction failed Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Co-authored-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * feat: Enhance --profile to load external profiles (#7292) * feat: --profile can load external profiles * fix external profile name method * fix ProfilesCompletionCandidate * test: Add unit tests * changelog: Update changelog * test: Fix TomlConfigurationDefaultProviderTest * test: Fix BesuCommandTest --------- Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Fix status badge for documentation (#7304) Documentation has been moved to GitHub pages and no longer use readthedocs. Updated the README status badge for docs with correct link Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * [MINOR] Fixed some typos (#7299) * typos Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * refactored to share one AuthorizedAccountService between the different instances of the world updater, renamed some classes Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * spotless Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * load code for authorization at the beginning of the transaction Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * ignore authorization if chain id doesn't match Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * cache authority address, evmtool: do not fail if sender address is wrong Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add evmtool block-test subcommand (#7293) * Add evmtool block-test subcommand Add an evmtool subcommand that will run non-hive blockchain tests. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Make the retrying snap tasks switching (#7307) * make snap tasks switching Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * 6612: Remove deprecated sync modes and related helper methods (#7309) * 6612: Remove deprecated sync modes and related helper methods Signed-off-by: Matilda-Clerke <matilda.shay.clerke@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * EOF Reference Test Fixes (#7306) Fix a number of issues found in reference tests and evmone tests. - Be tolerant of more nulls in json - Support ContainerKind in reference tests - re-order EXTCALL oeprands - correct return value for REVERT in EXT*CALL - re-order EOFCREATE code validation Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * test template refactor, bump besu-native to 0.9.2 (#7315) Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Feature/use gnark-crypto for eip-2537 (#7316) * use gnark-crypto for bls precompiles Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * 6612 update changelog with removed syncmodes (#7320) * 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update datacopy (#7319) Check for OOG earlier in DataCopy. Add unit tests to cover operation branches. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * disable flaky test (#7308) * disable flaky test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * disable flaky test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update unit test (#7317) * Update parameterized unit tests so the enumerate with --dry-run * Update the prague-withdrawal.json unit test to handle current code Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * persist accounts that have storage updates, but no nonce, balance nor code Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Revert "persist accounts that have storage updates, but no nonce, balance nor code" This reverts commit 9c9121a. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * removed PKI backed QBFT (#7310) * removed PKI backed QBFT Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * changelog Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * EIP-7251 add consolidation request type (#7266) * add request type for consolidations, encoder, decoder and tests * added raw tx for consolidation * add consolidation reqs to EngineGetPayloadResultV4 * set storage slot value to 0 initially and value for tx * updates plugin api Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix: `eth_call` deserialization to correctly ignore unknown fields in the transaction object (#7323) * fix: Use Builder for JsonCallParameter * changelog * add additional unit tests * fix: Update builder to withGas to match the json eth_call --------- Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Stop transaction selection on TX_EVALUATION_TOO_LONG (#7330) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * message frame buider will create AuthorizedCodeService by itsef if it isn't set Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * get correct nonce for authorization Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * nonce only returns a vaid nonce, new method nonceList returns all the nonces Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * plugs leaky abstraction Signed-off-by: Justin Florentine <justin+github@florentine.us> * some renaming, acceptance tests checks for exact balance of tx sponsor at the end. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * inject the 7702 code into DiffBasedWorldStateUpdateAccumulator.createAccount Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * spotless Signed-off-by: Justin Florentine <justin+github@florentine.us> * spotless fix, removed todos Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * make AuthorityProcessor & chain id for it optional Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: Ties <71668189+TiesD@users.noreply.github.com> Signed-off-by: Wolmin <lamonos123@gmail.com> Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Leni <leniram159@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Snazzy <snazzysam933@gmail.com> Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: Matilda-Clerke <matilda.shay.clerke@gmail.com> Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Co-authored-by: Chaminda Divitotawela <cdivitotawela@users.noreply.github.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Matt Whitehead <matthew.whitehead@kaleido.io> Co-authored-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Ties <71668189+TiesD@users.noreply.github.com> Co-authored-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com> Co-authored-by: Wolmin <44748271+Wolmin@users.noreply.github.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: leniram159 <leniram159@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Usman Saleem <usman@usmans.info> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: gringsam <snazzysam933@gmail.com> Co-authored-by: George Tebrean <99179176+gtebrean@users.noreply.github.com> Co-authored-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Co-authored-by: Matilda-Clerke <matilda.shay.clerke@gmail.com>

Gabriel-Trintinalia added 3 commits June 25, 2024 18:45

Initial implementation of system call for withdrawal requests

3f762dc

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Fix validations

5044e90

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge branch 'main' into implement-system-call

664a84f

Gabriel-Trintinalia added mainnet Prague labels Jun 26, 2024

Gabriel-Trintinalia mentioned this pull request Jun 26, 2024

Refactor EIP-7002 implementation to use contract #7259

Closed

Gabriel-Trintinalia marked this pull request as ready for review June 26, 2024 00:18

lucassaldanha reviewed Jun 26, 2024

View reviewed changes

macfarla reviewed Jun 26, 2024

View reviewed changes

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SystemCallProcessor.java Outdated Show resolved Hide resolved

jflo requested changes Jun 28, 2024

View reviewed changes

Gabriel-Trintinalia and others added 8 commits July 2, 2024 19:09

Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/main…

cce5d8f

…net/SystemCallProcessor.java Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/main…

6eaaa1a

…net/SystemCallProcessor.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

remove helper

4c7fed3

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

merge main into implement-system-call

6d11320

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

fix spotless

ede6bc6

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Accept PR recommendations

4851d1f

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Accept PR recommendations

ff6a90f

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge branch 'main' into implement-system-call

dfb4dbe

Gabriel-Trintinalia requested review from lucassaldanha, jflo, macfarla and shemnon July 3, 2024 05:24

jflo approved these changes Jul 3, 2024

View reviewed changes

Merge branch 'main' into implement-system-call

b769a62

shemnon suggested changes Jul 3, 2024

View reviewed changes

shemnon reviewed Jul 3, 2024

View reviewed changes

.../java/org/hyperledger/besu/ethereum/mainnet/requests/AbstractSystemCallRequestProcessor.java Outdated Show resolved Hide resolved

Gabriel-Trintinalia added 2 commits July 4, 2024 10:11

Do not throw exception if contract does not exist

87cdc4c

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Merge branch 'implement-system-call' of https://github.com/Gabriel-Tr…

2a02f33

…intinalia/besu into implement-system-call

Gabriel-Trintinalia requested a review from shemnon July 4, 2024 00:14

shemnon approved these changes Jul 4, 2024

View reviewed changes

Gabriel-Trintinalia merged commit 4ee14ec into hyperledger:main Jul 4, 2024
40 checks passed

Gabriel-Trintinalia mentioned this pull request Jul 9, 2024

Parameterize Withdrawal Request Address #7288

Closed

non-fungible-nelson mentioned this pull request Jul 11, 2024

EIP-7251 #7254

Closed

daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Jul 16, 2024

Implement System Calls (hyperledger#7263)

e4d0bdb

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Jul 16, 2024

Implement System Calls (hyperledger#7263)

aa62fb2

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Gabriel-Trintinalia mentioned this pull request Jul 22, 2024

Withdrawal Requests Contract system tx update differs from Geth #7289

Closed

macfarla mentioned this pull request Jul 26, 2024

Parameterize Consolidation Request contract address #7381

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement System Calls #7263

Implement System Calls #7263

Gabriel-Trintinalia commented Jun 25, 2024 •

edited

Loading

lucassaldanha left a comment

lucassaldanha Jun 26, 2024

jflo Jun 27, 2024

Gabriel-Trintinalia Jul 2, 2024 •

edited

Loading

jflo left a comment

jflo Jun 27, 2024

jflo Jun 27, 2024

shemnon Jun 28, 2024

shemnon Jun 28, 2024

lucassaldanha Jun 28, 2024

shemnon left a comment

shemnon commented Jul 3, 2024

Gabriel-Trintinalia commented Jul 4, 2024 •

edited

Loading

		public class WithdrawalRequestProcessor implements RequestProcessor {
		private static final Address WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS =

Implement System Calls #7263

Implement System Calls #7263

Conversation

Gabriel-Trintinalia commented Jun 25, 2024 • edited Loading

PR description

Fixed Issue(s)

lucassaldanha left a comment

Choose a reason for hiding this comment

lucassaldanha Jun 26, 2024

Choose a reason for hiding this comment

jflo Jun 27, 2024

Choose a reason for hiding this comment

Gabriel-Trintinalia Jul 2, 2024 • edited Loading

Choose a reason for hiding this comment

jflo left a comment

Choose a reason for hiding this comment

jflo Jun 27, 2024

Choose a reason for hiding this comment

jflo Jun 27, 2024

Choose a reason for hiding this comment

shemnon Jun 28, 2024

Choose a reason for hiding this comment

shemnon Jun 28, 2024

Choose a reason for hiding this comment

lucassaldanha Jun 28, 2024

Choose a reason for hiding this comment

shemnon left a comment

Choose a reason for hiding this comment

shemnon commented Jul 3, 2024

Gabriel-Trintinalia commented Jul 4, 2024 • edited Loading

Gabriel-Trintinalia commented Jun 25, 2024 •

edited

Loading

Gabriel-Trintinalia Jul 2, 2024 •

edited

Loading

Gabriel-Trintinalia commented Jul 4, 2024 •

edited

Loading