Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7732: Remove datagas related stuff in favour of blobgas #7353

Merged

Conversation

Matilda-Clerke
Copy link
Contributor

PR description

Remove datagas related stuff in favour of blobgas

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@fab-10
Copy link
Contributor

fab-10 commented Jul 19, 2024

Have the official specs changed? if so please add a link to it

@Matilda-Clerke
Copy link
Contributor Author

I took at look at some EIPs and found EIP-4844 only mentions blob gas, and doesn't mention data gas at all: https://eips.ethereum.org/EIPS/eip-4844#gas-accounting
I'm not sure on the history of such fields, but it appears this EIP is when they should have been introduced.

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the field was renamed a while back, but we had the old names in there until corresponding reference tests were updated. If the ref tests are passing, we can safely remove the old names now.

@macfarla macfarla merged commit 0269d83 into hyperledger:main Jul 21, 2024
40 checks passed
@Gabriel-Trintinalia
Copy link
Contributor

@fab-10
ethereum/EIPs#7354

gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
…7353)

* 7732: Remove datagas related stuff in favour of blobgas

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

---------

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants