Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change evmtool eof-test handling of empty code #7675

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Sep 24, 2024

PR description

In EOFTest, treat empty code as invalid.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

In EOFTest, treat empty code as invalid.

Signed-off-by: Danno Ferrin <danno@numisight.com>
@macfarla macfarla enabled auto-merge (squash) September 30, 2024 09:17
@macfarla macfarla merged commit 81f9fc9 into hyperledger:main Oct 4, 2024
43 checks passed
2fehee pushed a commit to 2fehee/besu that referenced this pull request Oct 4, 2024
In EOFTest, treat empty code as invalid.

Signed-off-by: Danno Ferrin <danno@numisight.com>Signed-off-by: Chulhee lee <leefehee@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants