Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore:Resolved EnginerGetClientVersionV1 fails for local build #7687

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Chore:Resolved EnginerGetClientVersionV1 fails for local build #7687

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5abc3a
Chore:Resolved EnginerGetClientVersionV1 fails for local build
pr9t Sep 27, 2024
ed9ae47
Merge branch 'main' into chore/EngineGetClientVersionV1Fails
macfarla Sep 29, 2024
cdf436c
formatting
macfarla Sep 29, 2024
78eec78
Merge branch 'main' into chore/EngineGetClientVersionV1Fails
macfarla Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...perledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineGetClientVersionV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,11 @@ public String getName() {

@Override
public JsonRpcResponse syncResponse(final JsonRpcRequestContext request) {
String safeCommit =
(commit != null && commit.length() >= 8) ? commit.substring(0, 8) : "unknown";
return new JsonRpcSuccessResponse(
request.getRequest().getId(),
new EngineGetClientVersionResultV1(
ENGINE_CLIENT_CODE, ENGINE_CLIENT_NAME, clientVersion, commit.substring(0, 8)));
ENGINE_CLIENT_CODE, ENGINE_CLIENT_NAME, clientVersion, safeCommit));
}
}
Loading