Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chainId in CallParameters #7720

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Oct 3, 2024

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the support-chainId-call-parameters branch from 0bbfe65 to c3a39b5 Compare October 3, 2024 15:35
@fab-10 fab-10 marked this pull request as ready for review October 3, 2024 15:42
@Filter94
Copy link
Contributor

Filter94 commented Oct 3, 2024

I think we should add a testcase to acceptance tests for this not to ever miss this again

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the support-chainId-call-parameters branch from c3a39b5 to 6df088d Compare October 3, 2024 17:00
@fab-10
Copy link
Contributor Author

fab-10 commented Oct 3, 2024

I think we should add a testcase to acceptance tests for this not to ever miss this again

Added tests that verify that in case the chainId does not match, then an error is returned, then added the chainId in some successful tests. Worth to know that in eth_estimateGas the chainId was added by default if the tx type requires it, this feature was not present on Linea and will be added.

@macfarla macfarla enabled auto-merge (squash) October 4, 2024 04:28
@macfarla macfarla merged commit 5fd87d6 into hyperledger:main Oct 4, 2024
43 checks passed
2fehee added a commit to 2fehee/besu that referenced this pull request Oct 4, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>Signed-off-by: Chulhee lee <leefehee@naver.com>
@fab-10 fab-10 deleted the support-chainId-call-parameters branch October 4, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants