Fix RocksDBException: Busy during snapsync #7746
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ported over from #7745)
PR description
Make TrieNodeHealingRequest.requiresPersisting thread safe.
Fixed Issue(s)
Fixes #7619
Testing
This is a hard to trigger race condition. Before this PR, the number of occurrences of this error was ~1 / 20 syncing nodes.
This has been tested on 60 nodes with CHECKPOINT sync and 20 nodes with SNAP sync and found no issues up to and including flat db healing. A few suffered from Backward sync halts but that is a later phase in the sync so I think unrelated.
The synced nodes' trie and flat dbs were also successfully verified with Bela.
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests