-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7311 add get headers from peer task #7781
Changes from 227 commits
2fb2690
f14aaeb
06553be
1ba5184
f2500dd
0992c35
33b810b
a378d22
15b6bdf
a9f6714
e3fbc6c
c03bffb
5e8b750
e4be5c0
bc11e0c
b2a45c2
513b74f
6b86919
645e0e3
4522414
28fc2cd
2364ed5
ced19cd
03f6495
5859444
9a4f3dd
97e5918
e0f736d
df7f62d
c335cbe
98aefcd
6e734f9
42ca85b
76724ed
fc9b3f2
08c66fd
049cae2
b6ec075
5afba63
3c1178c
5c3a61a
8448898
ab21100
2ac52f0
f2ac53e
3de578d
e901fdf
24e73a8
f077206
fa12495
6e349e1
ad86ae6
38f04ab
6de3fb3
da9cd43
ce7d245
c9eb22e
e2fda73
608fece
0e76000
2d07800
b910b4d
ad26297
96c8030
b0f2ed0
598b519
bc25b16
e31bb70
41923d3
720f94e
7d845b3
50c26f1
b7c0c95
a81855d
64adedc
2c1446e
3c0c47b
d0bd5ed
1c25ac5
2e6dfd9
aca8058
4d59b10
8718102
e63f473
fae39a8
d1847f2
07852dc
c477d70
6c57a7c
6d2cb95
d84520a
77ed748
0896e31
5f924c4
b13ac92
5006b39
07f3a7e
493ac91
1a30174
84af9f9
2865625
2f86ed9
82cedb0
bdd96ba
c047f42
5aa6b0b
4fd4724
d6120b0
8becdb3
4ad85e8
86a1f0b
8186a77
37b0ec2
545fd5c
7bd048b
e9d08f3
20478d3
4f544f4
66a9de2
3ddfe71
1c268b7
b06f38b
09ee1c8
3c12d3d
b1c47ae
4664db9
3b8b7d5
d66dd3a
fa22e93
cff0099
a3f5d4a
382f7a5
714db0a
3a68980
3ce476d
c422bc5
74aa7a0
56c1f9d
fe50d95
e733452
b3a252b
4f9cf52
af93824
3c96eba
fe27973
e664a51
7daf30f
c4e685d
6800cdd
302f2a8
00f51f3
44fd3a8
ac1c4ed
7503535
a59bd30
2989f2a
ed25941
4f4b091
c396fb5
2e5d6f4
ffe1c76
5a79636
0668083
3fa4f9c
8a34505
b075a91
74995bb
17edf67
2eaaf62
e2fea48
e5b7d0e
59d403a
2f2b295
875375e
1484f00
acf7b7c
1445f3f
87847fa
f11e695
58be140
095e31d
c2205c4
1b9922f
d827e68
26476ae
a357ecf
e7a13a4
e227e39
3d20f56
b0f57f8
5187afc
f1db42e
6ee320b
5419579
6b07948
61f57aa
149e65a
5fcad25
1923996
84b422c
8e6e2b0
24d8f99
7606ae5
1685e26
cc6c017
b75d453
7a975c8
5b7fbf2
6f8624c
3c597b0
99e6d0e
af53c9a
bbc1594
acc1191
5ce5fe9
ad4fd13
7ad664a
5a807b4
48e40c0
bedf3d0
130bfac
c2515bf
30c2c39
c925e6b
b3181c6
adcf088
b54fc14
ddceb7c
f002ba3
75b091a
371c192
d320d61
4618689
dd15253
128d300
59d4912
48b224e
bc4d963
a30f2c4
979b761
e90c003
497e22b
c683304
8efad37
639ef87
a0d16b0
4dd3875
d221706
7df7688
2fde29f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ | |
import org.hyperledger.besu.ethereum.core.MiningConfiguration; | ||
import org.hyperledger.besu.ethereum.core.Util; | ||
import org.hyperledger.besu.ethereum.eth.manager.EthProtocolManager; | ||
import org.hyperledger.besu.ethereum.eth.manager.peertask.PeerTaskExecutor; | ||
import org.hyperledger.besu.ethereum.eth.sync.state.SyncState; | ||
import org.hyperledger.besu.ethereum.eth.transactions.TransactionPool; | ||
import org.hyperledger.besu.ethereum.mainnet.ProtocolSchedule; | ||
|
@@ -84,6 +85,7 @@ protected MiningCoordinator createMiningCoordinator( | |
final ProtocolContext protocolContext, | ||
final TransactionPool transactionPool, | ||
final MiningConfiguration miningConfiguration, | ||
final PeerTaskExecutor peerTaskExecutor, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like we need are adding unused dependencies on peerTaskExecutor via the createMiningCoordinator method inherited from the BesuControllerBuilderInterface. Is there a way around that? Perhaps overloading the method and providing a default implementation to be used by subclasses that don't care about it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, good idea There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, I can't really find a way around it. Overloading won't help because it's called from within BesuControllerBuilder, which can't make the distinction between which subclasses need the PeerTaskExecutor and which don't |
||
final SyncState syncState, | ||
final EthProtocolManager ethProtocolManager) { | ||
final CliqueMinerExecutor miningExecutor = | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the
PeerTaskExecutor
to theEthContext
could be a nice home for this and save a lot of changes to wire through thePeerTaskExecutor
through all the tasks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this is done now. Let me know what you think of the changes