Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registering new metric categories from plugins #7825

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Oct 29, 2024

PR description

This PR fixes an issue with new metric categories registered by plugins and enabled via metrics-categories option, since when the plugin registers them it is already too late in the startup process, and Besu fails reporting an unknown metric category option.
To fix this, the validation of the metric categories have been postponed to the moment we build the metric configuration from the metrics options, because at that point all is set.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the fix-metric-category-registration-from-plugin branch from e3f468a to abe8635 Compare October 29, 2024 17:06
@fab-10 fab-10 self-assigned this Oct 29, 2024
@fab-10 fab-10 force-pushed the fix-metric-category-registration-from-plugin branch 2 times, most recently from 9f04a46 to 26fbea9 Compare October 29, 2024 19:16
@fab-10 fab-10 marked this pull request as ready for review October 30, 2024 13:36
@jflo
Copy link
Contributor

jflo commented Oct 30, 2024

fixes #7818

Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great move getting rid of the need for converters

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the fix-metric-category-registration-from-plugin branch from 26fbea9 to 2b42d31 Compare October 30, 2024 14:48
@fab-10 fab-10 merged commit 22a570e into hyperledger:main Oct 30, 2024
43 checks passed
@fab-10 fab-10 deleted the fix-metric-category-registration-from-plugin branch October 30, 2024 15:21
JanetMo pushed a commit to JanetMo/besu that referenced this pull request Nov 17, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants