Pass correct updater to traceEndTransaction #7886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
lu-pinto
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
LGTM, I actually think we should pass a fork of the evmWorldUpdater to every tracer call. I think this might still fix some other odd case and make it consistent to avoid any confusions.
@daniellehrner for context, this came up while working together with Linea. Since you made the changes to support account abstraction and EvmWorldUpdater was introduced there, it would be great to have your input
daniellehrner
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Provide the correct updater to
traceEndTransactionto ensure consistency with other calls.