Add TLS/mTLS options and configure the GraphQL HTTP service #7910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2024 12:50
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
requested changes
Dec 3, 2024
| @@ -0,0 +1,545 @@ | |||
| /* | |||
| * Copyright ConsenSys AG. | |||
There was a problem hiding this comment.
newly added files should be Copyright contributors to Besu.
There was a problem hiding this comment.
Suggested change
| * Copyright ConsenSys AG. | |
| * Copyright contributors to Besu. |
| Assertions.assertThat(redirectUrl).isNotNull(); | ||
| final Request.Builder redirectBuilder = resp.request().newBuilder(); | ||
| redirectBuilder.get(); | ||
| // resp.body().close(); |
| } | ||
|
|
||
| @Test | ||
| public void ethGetUncleCountByBlockHash() throws Exception { |
There was a problem hiding this comment.
can this test use getBlockNumber or something more basic? PoW is deprecated so ommers might go away at some point
bgravenorst
added
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
The changes include the addition of command-line options to enable and configure TLS and mTLS for the GraphQL HTTP service.
Changes
New Command-Line Options:
--graphql-tls-enabled: Enable TLS for the GraphQL HTTP service.--graphql-tls-keystore-file: Path to the TLS keystore file.--graphql-tls-keystore-password-file: Path to the file containing the password for the TLS keystore.--graphql-mtls-enabled: Enable mTLS for the GraphQL HTTP service.--graphql-tls-truststore-file: Path to the TLS truststore file.--graphql-tls-truststore-password-file: Path to the file containing the password for the TLS truststore.Validation of Option Dependencies:
Testing
Documentation
CHANGELOG.mdto reflect the addition of new TLS options.Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests