Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rebuild trie from flat #7969

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Feature/rebuild trie from flat #7969

wants to merge 12 commits into from

Conversation

garyschulte
Copy link
Contributor

PR description

Implement a storage subcommand to rebuild the bonsai state trie from flat db

Fixed Issue(s)

fixes #7934

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@garyschulte garyschulte force-pushed the feature/rebuild-trie-from-flat branch 2 times, most recently from 761f8f5 to 6246c3b Compare December 4, 2024 18:43
@garyschulte
initial commit for rebuild state trie command, compiles, untested.
8917488 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
added unit test for state rebuild command
77c79cd 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
add to the storage subcommand
d86a966 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
add batching to prevent heap overflow
98e9e2e 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
spotless and additional error detail
a109b18 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
fix encode trie value for account state
255f08f 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
GC merkle tries on interim commits, spotless.
2cd2b8f 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the feature/rebuild-trie-from-flat branch 2 times, most recently from 14437fc to 2cd2b8f Compare December 5, 2024 18:19
@garyschulte
add more logging, drop forced commit interval to 5k
f81531e 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
prefix rather than postfix eval for counter increment
2f99303 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
use single transaction for both accounts and account storage
5b079b8 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
don't use wrapped tx interim commits
057c7b3 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
explicit stream close
6ee77c9 
Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subcommand to recreate state trie from flat db
1 participant
@garyschulte