Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_call state override bugfix - movePrecompileToAddress #8024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Dec 13, 2024

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

Builder needed to ignore unknown properties also

Fixed Issue(s)

Fixes #8023

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) December 13, 2024 03:36
@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) December 13, 2024 03:52
@macfarla macfarla disabled auto-merge December 13, 2024 04:05
@macfarla macfarla merged commit 98780ef into hyperledger:main Dec 13, 2024
43 checks passed
macfarla added a commit to macfarla/besu that referenced this pull request Dec 16, 2024
…#8024)

* add ignore unknown prop to builder

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Dec 18, 2024
…#8024)

* add ignore unknown prop to builder

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulation - Implement movePrecompileToAddress for state override
2 participants