Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return rpc error in eth_getLogs on unknown block hash #8051

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Return rpc error in eth_getLogs on unknown block hash

a61efeb
Select commit
Loading
Failed to load commit list.
Open

Return rpc error in eth_getLogs on unknown block hash #8051

Return rpc error in eth_getLogs on unknown block hash
a61efeb
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Dec 18, 2024 in 0s

Check failed

All commits are incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🔴 a61efeb Return rpc error in eth_getLogs on unknown block h... Sign-off not found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Amend last commit

To fix the incorrectly signed off commit:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git commit --amend --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin eth_getlogs-error-on-unknown-hash