Dont touch state for CALLs raising a static exception #8639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR does two things:
LOGX
that raise a static exceptionCALL
that raises a static exceptionNote. Computing the cost of a value-bearing
CALL
requires a state access: one must determine whether the target address exists in the state. In the code this state access was implicitly performed duringcost(frame, true)
. If theCALL
raises a static exception this state access is not required; it also pollutes the accumulator. In the fix we therefore remove this cost calculation and replace it with 0. We also remove the cost calculation forLOGX
operations that raise a static exception.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests