Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType #2553

Closed
petermetz opened this issue Jul 16, 2023 · 1 comment · Fixed by #2554
Closed

fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType #2553

petermetz opened this issue Jul 16, 2023 · 1 comment · Fixed by #2554
Assignees
@petermetz
Labels
bug Something isn't working good-first-issue Good for newcomers good-first-issue-100-introductory IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. P2 Priority 2: High

Comments

@petermetz
Copy link
Contributor

Description

Specifically this value CommitFinalResponse = "urn:ietf:odap:msgtype:commit-ack-msg", should be
urn:ietf:odap:msgtype:commit-final-ack-msg as per the IETF draft's section 8.4

Screenshot from 2023-07-16 13-29-01

https://datatracker.ietf.org/doc/html/draft-hargreaves-odap-03#section-8.4

cc: @RafaelAPB @AndreAugusto11
@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers good-first-issue-100-introductory P2 Priority 2: High IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. labels Jul 16, 2023
@petermetz petermetz self-assigned this Jul 16, 2023
petermetz added a commit to petermetz/cacti that referenced this issue Jul 16, 2023
@petermetz
fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType
6e02703 
CommitFinalResponse and CommitPreparationResponse
were accidentally having the same enum value, fixed it by
providing the correct enum value (as per the specs) for
CommitFinalResponse.

Links:
1. https://datatracker.ietf.org/doc/bofreq-hardjono-secure-asset-transfer-protocol/
2. https://www.ietf.org/archive/id/draft-hargreaves-odap-03.txt

Fixes hyperledger-cacti#2553

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jul 16, 2023
Merged
@AndreAugusto11
Copy link
Contributor

Thank you @petermetz!

petermetz added a commit to petermetz/cacti that referenced this issue Jul 20, 2023
@petermetz
fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType
2308dcd 
CommitFinalResponse and CommitPreparationResponse
were accidentally having the same enum value, fixed it by
providing the correct enum value (as per the specs) for
CommitFinalResponse.

Links:
1. https://datatracker.ietf.org/doc/bofreq-hardjono-secure-asset-transfer-protocol/
2. https://www.ietf.org/archive/id/draft-hargreaves-odap-03.txt

Fixes hyperledger-cacti#2553

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 22, 2023
@petermetz
fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType
0c8aa20 
CommitFinalResponse and CommitPreparationResponse
were accidentally having the same enum value, fixed it by
providing the correct enum value (as per the specs) for
CommitFinalResponse.

Links:
1. https://datatracker.ietf.org/doc/bofreq-hardjono-secure-asset-transfer-protocol/
2. https://www.ietf.org/archive/id/draft-hargreaves-odap-03.txt

Fixes hyperledger-cacti#2553

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Jul 22, 2023
@petermetz
fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType
292d287 
CommitFinalResponse and CommitPreparationResponse
were accidentally having the same enum value, fixed it by
providing the correct enum value (as per the specs) for
CommitFinalResponse.

Links:
1. https://datatracker.ietf.org/doc/bofreq-hardjono-secure-asset-transfer-protocol/
2. https://www.ietf.org/archive/id/draft-hargreaves-odap-03.txt

Fixes #2553

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@petermetz @sandeepnRES
fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType
dba84f9 
CommitFinalResponse and CommitPreparationResponse
were accidentally having the same enum value, fixed it by
providing the correct enum value (as per the specs) for
CommitFinalResponse.

Links:
1. https://datatracker.ietf.org/doc/bofreq-hardjono-secure-asset-transfer-protocol/
2. https://www.ietf.org/archive/id/draft-hargreaves-odap-03.txt

Fixes hyperledger-cacti#2553

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working good-first-issue Good for newcomers good-first-issue-100-introductory IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. P2 Priority 2: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType petermetz/cacti
2 participants
@petermetz @AndreAugusto11