Skip to content

Commit

Permalink
fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType
Browse files Browse the repository at this point in the history
CommitFinalResponse and CommitPreparationResponse
were accidentally having the same enum value, fixed it by
providing the correct enum value (as per the specs) for
CommitFinalResponse.

Links:
1. https://datatracker.ietf.org/doc/bofreq-hardjono-secure-asset-transfer-protocol/
2. https://www.ietf.org/archive/id/draft-hargreaves-odap-03.txt

Fixes hyperledger-cacti#2553

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Jul 22, 2023
1 parent 8f1d1f3 commit 0c8aa20
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export enum OdapMessageType {
CommitPreparationRequest = "urn:ietf:odap:msgtype:commit-prepare-msg",
CommitPreparationResponse = "urn:ietf:odap:msgtype:commit-ack-msg",
CommitFinalRequest = "urn:ietf:odap:msgtype:commit-final-msg",
CommitFinalResponse = "urn:ietf:odap:msgtype:commit-ack-msg",
CommitFinalResponse = "urn:ietf:odap:msgtype:commit-final-ack-msg",
TransferCompleteRequest = "urn:ietf:odap:msgtype:commit-transfer-complete-msg",
}

Expand Down

0 comments on commit 0c8aa20

Please sign in to comment.