feat(go-ethereum-socketio): remove deprecated connector #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
approved these changes
Jun 21, 2024
- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and any reference to it. - Remove `SocketIOApiClient` from `cactus-api-client` since it is the last connector that was linked to it. - Remove `legacy-socketio` option from `cactus-verifier-client`. Part of hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
force-pushed
the
remove_eth_socketio_connector_pr
branch
from
c35e314 to
6cb6fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cactus-plugin-ledger-connector-go-ethereum-socketioconnector and any reference to it.SocketIOApiClientfromcactus-api-clientsince it is the last connector that was linked to it.legacy-socketiooption fromcactus-verifier-client.Part of #3155
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.