-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(plugins): remove deprecated packages #3155
Comments
- `cactus-example-tcs-huawei` is using `cactus-plugin-ledger-connector-go-ethereum-socketio` and `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will be removed as well. Ths sample app can't exist on it's own. Closes: hyperledger-cacti#3157 Part of: hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
…onnector - Iroha connector is broken for some time and it's SDK does't seem to be actively supported anymore (in regards of bug or security fixes). Closes: hyperledger-cacti#3159 Part of: hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH Thank you for putting this together! |
…onnector - Iroha connector is broken for some time and it's SDK does't seem to be actively supported anymore (in regards of bug or security fixes). Closes: hyperledger-cacti#3159 Part of: hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- `cactus-example-tcs-huawei` is using `cactus-plugin-ledger-connector-go-ethereum-socketio` and `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will be removed as well. Ths sample app can't exist on it's own. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue hyperledger-cacti#3155 on github for more details on context and reasoning of this decision. Closes: hyperledger-cacti#3157 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH good initiative. Agree with all - I will do things on my end to remove the Ubiquity package (if/when we have support for this plugin within BD we can add it again) |
- `cactus-example-tcs-huawei` is using `cactus-plugin-ledger-connector-go-ethereum-socketio` and `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will be removed as well. Ths sample app can't exist on it's own. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue hyperledger-cacti#3155 on github for more details on context and reasoning of this decision. Closes: hyperledger-cacti#3157 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- `cactus-example-tcs-huawei` is using `cactus-plugin-ledger-connector-go-ethereum-socketio` and `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will be removed as well. Ths sample app can't exist on it's own. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue #3155 on github for more details on context and reasoning of this decision. Closes: #3157 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and any reference to it. - Remove `SocketIOApiClient` from `cactus-api-client` since it is the last connector that was linked to it. - Remove `legacy-socketio` option from `cactus-verifier-client`. Part of hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and any reference to it. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue hyperledger-cacti#3155 on github for more details on context and reasoning of this decision. Part of hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
…onnector - Iroha connector is broken for some time and it's SDK does't seem to be actively supported anymore (in regards of bug or security fixes). Closes: hyperledger-cacti#3159 Part of: hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- `cactus-example-tcs-huawei` is using `cactus-plugin-ledger-connector-go-ethereum-socketio` and `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will be removed as well. Ths sample app can't exist on it's own. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue hyperledger-cacti#3155 on github for more details on context and reasoning of this decision. Closes: hyperledger-cacti#3157 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and any reference to it. - Remove `SocketIOApiClient` from `cactus-api-client` since it is the last connector that was linked to it. - Remove `legacy-socketio` option from `cactus-verifier-client`. Part of hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and any reference to it. - Remove `SocketIOApiClient` from `cactus-api-client` since it is the last connector that was linked to it. - Remove `legacy-socketio` option from `cactus-verifier-client`. Part of #3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and any reference to it. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue hyperledger-cacti#3155 on github for more details on context and reasoning of this decision. Part of hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and any reference to it. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue hyperledger-cacti#3155 on github for more details on context and reasoning of this decision. Part of hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and any reference to it. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue hyperledger-cacti#3155 on github for more details on context and reasoning of this decision. Part of hyperledger-cacti#3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and any reference to it. - This is not permanent - we'd love to bring the package back once the necessary refactors are done! - See issue #3155 on github for more details on context and reasoning of this decision. Part of #3155 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH From what I can tell this has already been done: All the non-crossed out packages are actually missing from the codebase. Sounds like mission accomplished, thank you again! :-) |
A bit late to the party, but thanks again for executing brilliantly this small behemoth of a task. |
Deprecate and remove some older connectors and docker images as it was initially discussed during maintainer meetings https://wiki.hyperledger.org/display/cactus/2024-03-14+Cacti+Maintainers+Agenda and https://wiki.hyperledger.org/display/cactus/2024-03-20+Cacti+Maintainers+Agenda.
The list of packages to be deprecated and removed
cacti-ledger-browser
cacti-ledger-browser-react
ascacti-ledger-browser
. I did not realize we've added a separate package in PR, sorry.cactus-cmd-socketio-server
cactus-plugin-ledger-connector-go-ethereum-socketio
cactus-plugin-ledger-connector-ethereum
, should not be used anymore.cactus-plugin-ledger-connector-iroha
docker/iroha-all-in-one
cactus-test-tooling
.docker/fabric-all-in-one V 1.4
cactus-test-tooling
and upgrade any remaining tests and sample apps that use V1 (if any).cactus-plugin-ledger-connector-tcs-huawei-socketio
cactus-example-tcs-huawei
go-ethereum-socketio
andtcs-huawei-socketio
connectors.cactus-plugin-ledger-connector-ubiquity
cactus-plugin-ledger-connector-quorum
Deprecation and package removal is not final
If there's a need to bring some of these packages back, or if the package gets refactored so that it matches
the state of other cacti packages, then the package can be restored. Removed packages can still be accessed by checking-out the state of this repo before the removal (I'll add appropriate commits next to the removed plugins on the list as the PR get merged).
Motivation
We want to clean up older connectors before V2 release to simplify maitanance in the future. More packages means more dependencies that must be regularry checked and updated (security fixes), some of these packages are also deprecetad mainstream / by authors.
CC
@izuru0 @petermetz @takeutak @jagpreetsinghsasan @VRamakrishna @sandeepnRES @RafaelAPB @123wyl123
The text was updated successfully, but these errors were encountered: