Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugins): remove deprecated packages #3155

Closed
outSH opened this issue Mar 29, 2024 · 4 comments
Closed

chore(plugins): remove deprecated packages #3155

outSH opened this issue Mar 29, 2024 · 4 comments
Labels
enhancement New feature or request P2 Priority 2: High Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.

Comments

@outSH
Copy link
Contributor

outSH commented Mar 29, 2024

Deprecate and remove some older connectors and docker images as it was initially discussed during maintainer meetings https://wiki.hyperledger.org/display/cactus/2024-03-14+Cacti+Maintainers+Agenda and https://wiki.hyperledger.org/display/cactus/2024-03-20+Cacti+Maintainers+Agenda.

The list of packages to be deprecated and removed

Deprecation and package removal is not final

If there's a need to bring some of these packages back, or if the package gets refactored so that it matches
the state of other cacti packages, then the package can be restored. Removed packages can still be accessed by checking-out the state of this repo before the removal (I'll add appropriate commits next to the removed plugins on the list as the PR get merged).

Motivation

We want to clean up older connectors before V2 release to simplify maitanance in the future. More packages means more dependencies that must be regularry checked and updated (security fixes), some of these packages are also deprecetad mainstream / by authors.

CC

@izuru0 @petermetz @takeutak @jagpreetsinghsasan @VRamakrishna @sandeepnRES @RafaelAPB @123wyl123

@outSH outSH added enhancement New feature or request Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule. P2 Priority 2: High labels Mar 29, 2024
outSH added a commit to outSH/cactus that referenced this issue Mar 29, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.

Closes: hyperledger-cacti#3157
Part of: hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Mar 29, 2024
…onnector

- Iroha connector is broken for some time and it's SDK does't seem to be
    actively supported anymore (in regards of bug or security fixes).

Closes: hyperledger-cacti#3159
Part of: hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@petermetz
Copy link
Contributor

@outSH Thank you for putting this together!

petermetz pushed a commit to outSH/cactus that referenced this issue Apr 1, 2024
…onnector

- Iroha connector is broken for some time and it's SDK does't seem to be
    actively supported anymore (in regards of bug or security fixes).

Closes: hyperledger-cacti#3159
Part of: hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit that referenced this issue Apr 1, 2024
…onnector

- Iroha connector is broken for some time and it's SDK does't seem to be
    actively supported anymore (in regards of bug or security fixes).

Closes: #3159
Part of: #3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Apr 2, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Closes: hyperledger-cacti#3157

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@RafaelAPB
Copy link
Contributor

@outSH good initiative. Agree with all - I will do things on my end to remove the Ubiquity package (if/when we have support for this plugin within BD we can add it again)

outSH added a commit to outSH/cactus that referenced this issue Jun 20, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Closes: hyperledger-cacti#3157

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit that referenced this issue Jun 20, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue #3155 on github for more details on context and reasoning
    of this decision.

Closes: #3157

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jun 20, 2024
- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and
  any reference to it.
- Remove `SocketIOApiClient` from `cactus-api-client` since it is the
  last connector that was linked to it.
- Remove `legacy-socketio` option from `cactus-verifier-client`.

Part of hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jun 20, 2024
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and
  any reference to it.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Part of hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Jul 30, 2024
…onnector

- Iroha connector is broken for some time and it's SDK does't seem to be
    actively supported anymore (in regards of bug or security fixes).

Closes: hyperledger-cacti#3159
Part of: hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Jul 30, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Closes: hyperledger-cacti#3157

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Aug 6, 2024
- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and
  any reference to it.
- Remove `SocketIOApiClient` from `cactus-api-client` since it is the
  last connector that was linked to it.
- Remove `legacy-socketio` option from `cactus-verifier-client`.

Part of hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit that referenced this issue Aug 6, 2024
- Remove `cactus-plugin-ledger-connector-go-ethereum-socketio` connector and
  any reference to it.
- Remove `SocketIOApiClient` from `cactus-api-client` since it is the
  last connector that was linked to it.
- Remove `legacy-socketio` option from `cactus-verifier-client`.

Part of #3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Aug 7, 2024
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and
  any reference to it.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Part of hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit to outSH/cactus that referenced this issue Aug 8, 2024
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and
  any reference to it.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Part of hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Aug 8, 2024
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and
  any reference to it.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Part of hyperledger-cacti#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit that referenced this issue Aug 8, 2024
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and
  any reference to it.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue #3155 on github for more details on context and reasoning
    of this decision.

Part of #3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@petermetz
Copy link
Contributor

@outSH From what I can tell this has already been done: All the non-crossed out packages are actually missing from the codebase. Sounds like mission accomplished, thank you again! :-)

@RafaelAPB
Copy link
Contributor

A bit late to the party, but thanks again for executing brilliantly this small behemoth of a task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Priority 2: High Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.
Projects
None yet
Development

No branches or pull requests

3 participants