Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd-api-server): add missing deps remove unused ones #1226

Closed
petermetz opened this issue Aug 16, 2021 · 0 comments · Fixed by #1228
Closed

fix(cmd-api-server): add missing deps remove unused ones #1226

petermetz opened this issue Aug 16, 2021 · 0 comments · Fixed by #1228
Assignees
@petermetz
Labels
API_Server bug Something isn't working
Milestone
v0.9.0

Comments

@petermetz
Copy link
Contributor 

$ npx dependency-check ./packages/cactus-cmd-api-server/dist/lib/main/typescript/index.js 

Fail! Modules in package.json not used in code: 
express-jwt-authz, http-status-codes, @hyperledger/cactus-plugin-keychain-vault, @hyperledger/cactus-test-tooling,
@types/compression, @types/convict, @types/cors, @types/express, @types/express-http-proxy, @types/express-jwt,
@types/jsonwebtoken, @types/multer, @types/node-forge, @types/passport, @types/passport-oauth2,
@types/passport-saml, @types/passport-strategy, @types/semver, @types/uuid, @types/xml2js
Fail! Dependencies not listed in package.json: run-time-error
@petermetz petermetz added bug Something isn't working API_Server labels Aug 16, 2021
@petermetz petermetz added this to the v0.8.0 milestone Aug 16, 2021
@petermetz petermetz self-assigned this Aug 16, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Aug 16, 2021
@petermetz
fix(cmd-api-server): add missing deps remove unused ones hyperledger-…
7df0245 
…cacti#1226

Fixes hyperledger-cacti#1226

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Aug 16, 2021
Merged
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
petermetz added a commit that referenced this issue Aug 18, 2021
@petermetz
fix(cmd-api-server): add missing deps remove unused ones #1226
b348e42 
Fixes #1226

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Aug 27, 2021
@petermetz @Leeyoungone
fix(cmd-api-server): add missing deps remove unused ones hyperledger-…
474d2db 
…cacti#1226

Fixes hyperledger-cacti#1226

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@petermetz @RafaelAPB
fix(cmd-api-server): add missing deps remove unused ones hyperledger-…
e23c8d7 
…cacti#1226

Fixes hyperledger-cacti#1226

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
API_Server bug Something isn't working
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

fix(cmd-api-server): add missing deps remove unused ones #1226 petermetz/cacti
1 participant
@petermetz