Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-odap-hermes): remove extraneous dependencies #1641

Closed
petermetz opened this issue Dec 8, 2021 · 0 comments · Fixed by #1643
Closed

fix(plugin-odap-hermes): remove extraneous dependencies #1641

petermetz opened this issue Dec 8, 2021 · 0 comments · Fixed by #1643
Assignees
@petermetz
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P3 Priority 3: Medium Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.

Comments

@petermetz
Copy link
Contributor

There are dependencies specified for the package which do not need to be because
they are already dependencies on the top level. We need to clena these up so that
the build performance is improved (yarn configure will take less time)

Assignees: @petermetz
Labels: dependencies,Developer_Experience,bug
@petermetz petermetz self-assigned this Dec 8, 2021
@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. P3 Priority 3: Medium labels Dec 8, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Dec 8, 2021
@petermetz
fix(plugin-odap-hermes): remove extraneous dependencies
5595a4f 
1. Removed a lot of extraneous dependencies and
2. Changed the license to Apache-2.0 from ISC

Fixes hyperledger-cacti#1641

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Dec 8, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Dec 8, 2021
@petermetz
fix(plugin-odap-hermes): remove extraneous dependencies
636dfd9 
1. Removed a lot of extraneous dependencies and
2. Changed the license to Apache-2.0 from ISC

Fixes hyperledger-cacti#1641

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Dec 17, 2021
@petermetz
fix(plugin-odap-hermes): remove extraneous dependencies
87af023 
1. Removed a lot of extraneous dependencies and
2. Changed the license to Apache-2.0 from ISC

Fixes #1641

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P3 Priority 3: Medium Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-odap-hermes): remove extraneous dependencies petermetz/cacti
1 participant
@petermetz