Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector-xdai): add ledger connector plugin for xdai #852

Closed
petermetz opened this issue Apr 23, 2021 · 0 comments · Fixed by #855
Closed

feat(connector-xdai): add ledger connector plugin for xdai #852

petermetz opened this issue Apr 23, 2021 · 0 comments · Fixed by #855
Assignees
@petermetz
Labels
enhancement New feature or request Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus

Comments

@petermetz
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We need an xdai connector.

Describe the solution you'd like

Mostly a copy paste fork of the besu connector for now.

Describe alternatives you've considered

Putting more effort into writing a common, re-usable backbone for all the web3 flavored connectors.
Not necessarily a bad idea, but inheritance can be a pain instead of composition. Sometimes it's better to be a little repetitive. We'll see...

Additional context

Needed for the carbon accounting app example.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan @arnab-roy
@petermetz petermetz added enhancement New feature or request Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus labels Apr 23, 2021
@petermetz petermetz self-assigned this Apr 23, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(connector-xdai): add ledger connector plugin for xdai hyperledge…
ccfa235 
…r-cacti#852

Fixes hyperledger-cacti#852

WORK IN PROGRESS

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(connector-xdai): add ledger connector plugin for xdai hyperledge…
16b2353 
…r-cacti#852

A 1 to 1 clone of the besu connector for now but I thought it best
to keep it separate regardless because a lot of Besu specific
changes are about to drop for the Besu connector as we add the
differentiating features of it to the connector as well and
once that happens the codebases will probably look quite
different at that point.

Fixes hyperledger-cacti#852

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(connector-xdai): add ledger connector plugin for xdai hyperledge…
2bc006d 
…r-cacti#852

A 1 to 1 clone of the besu connector for now but I thought it best
to keep it separate regardless because a lot of Besu specific
changes are about to drop for the Besu connector as we add the
differentiating features of it to the connector as well and
once that happens the codebases will probably look quite
different at that point.

Fixes hyperledger-cacti#852

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Apr 23, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(connector-xdai): add ledger connector plugin for xdai hyperledge…
29bc515 
…r-cacti#852

A 1 to 1 clone of the besu connector for now but I thought it best
to keep it separate regardless because a lot of Besu specific
changes are about to drop for the Besu connector as we add the
differentiating features of it to the connector as well and
once that happens the codebases will probably look quite
different at that point.

Fixes hyperledger-cacti#852

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Apr 29, 2021
@petermetz
feat(connector-xdai): add ledger connector plugin for xdai #852
99399a3 
A 1 to 1 clone of the besu connector for now but I thought it best
to keep it separate regardless because a lot of Besu specific
changes are about to drop for the Besu connector as we add the
differentiating features of it to the connector as well and
once that happens the codebases will probably look quite
different at that point.

Fixes #852

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
enhancement New feature or request Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(connector-xdai): add ledger connector plugin for xdai #852 petermetz/cacti
1 participant
@petermetz