feat(connector-xdai): add ledger connector plugin for xdai #852 #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
added
enhancement
We did not need to roll our own contanier image for this so the only thing new here is the class in the test tooling package that makes it convenient to write test cases against OpenEthereum. The container image used by the class behind the scenes is just the stock OpenEthereum image from DockerHub. Fixes hyperledger-cacti#851 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
…r-cacti#852 A 1 to 1 clone of the besu connector for now but I thought it best to keep it separate regardless because a lot of Besu specific changes are about to drop for the Besu connector as we add the differentiating features of it to the connector as well and once that happens the codebases will probably look quite different at that point. Fixes hyperledger-cacti#852 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
takeutak
approved these changes
Apr 26, 2021
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Depends on #854
Commit to review
Author: Peter Somogyvari peter.somogyvari@accenture.com
Author Date: 2021-04-23 14:47:01 -0700
Committer: Peter Somogyvari peter.somogyvari@accenture.com
Committer Date: 2021-04-23 14:53:42 -0700
feat(connector-xdai): add ledger connector plugin for xdai #852
A 1 to 1 clone of the besu connector for now but I thought it best
to keep it separate regardless because a lot of Besu specific
changes are about to drop for the Besu connector as we add the
differentiating features of it to the connector as well and
once that happens the codebases will probably look quite
different at that point.
Fixes #852
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com