Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add carbon-account-app #540 #856

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Apr 24, 2021

Dependencies

Depends on #861
Depends on #855
Depends on #854
Depends on #841

Commit to review

Author: Peter Somogyvari peter.somogyvari@accenture.com
Author Date: Fri Apr 23 2021 15:00:07 GMT-0700 (Pacific Daylight Time)
Committer: Peter Somogyvari peter.somogyvari@accenture.com
Committer Date: Fri Apr 23 2021 21:02:19 GMT-0700 (Pacific Daylight Time)

docs(examples): add carbon-account-app #540

Fixes #540

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz petermetz added documentation Improvements or additions to documentation Fabric Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus labels Apr 24, 2021
@petermetz petermetz force-pushed the docs-540 branch 2 times, most recently from 0de1f02 to bfd6586 Compare April 25, 2021 04:01
@petermetz petermetz self-assigned this Apr 25, 2021
@petermetz petermetz marked this pull request as ready for review April 25, 2021 04:02
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was overlooked by GitHub's auto-rebase of the PR
that introduced this issue so hot-fixing this
ASAP in order to stop blocking every single new PR from running the CI
suite correctly.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
These are methods that come in handy while working with
Fabric networks.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Provides an example of how to build an application
with batteries included that has the carbon accounting
tool's smart contracts for xdai and Fabric baked in it.

There's test coverage for the JWT based authorization
layer and a clone of the enroll admin REST API endpoint
of the carbon accounting tool (which I picked because
there's an open bug about it in the carbon accounting
tool's github issue tracker at the time of this writing).

Fixes hyperledger-cacti#540

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@petermetz petermetz merged commit 1701b3b into hyperledger-cacti:main Apr 30, 2021
@petermetz petermetz deleted the docs-540 branch April 30, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Fabric Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(examples): add carbon-account-app
3 participants