Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: upgrade umi version to 3.0 #153

Merged
merged 2 commits into from
May 21, 2020

Conversation

hightall
Copy link
Contributor

fix #152

Signed-off-by: Haitao Yue hihghtallyht@gmail.com

fix hyperledger#152

Signed-off-by: Haitao Yue <hihghtallyht@gmail.com>
@hightall hightall requested a review from a team May 19, 2020 14:11
@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request fixes 1 alert when merging c40b7bb into 04a5c4d - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Signed-off-by: Haitao Yue <hihghtallyht@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request fixes 1 alert when merging 50766f8 into 04a5c4d - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hightall hightall self-assigned this May 19, 2020
@litong01
Copy link
Contributor

@hightall you got 2 commits in this PR. Can you squash them into one?

@litong01
Copy link
Contributor

A lot of checks also failed on the second commit.

@yeasy
Copy link
Member

yeasy commented May 20, 2020

This is an important change, let's review carefully to avoid breaking existing functionalities.
@hightall @litong01 @jiahaoc1993

@hightall
Copy link
Contributor Author

@litong01 it's netlify build, I have removed it, it's just a demo site deployment.

@litong01 litong01 merged commit 754afa4 into hyperledger:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade umi version to 3.0
3 participants